From 1667d0caa43fcf8d22404062d0647da971a0b5db Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Thu, 12 Sep 2019 15:25:03 -0700 Subject: [PATCH] rename port to web-port and hostname to web-hostname (#40370) --- packages/flutter_tools/lib/src/commands/run.dart | 4 ++-- packages/flutter_tools/lib/src/runner/flutter_command.dart | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/flutter_tools/lib/src/commands/run.dart b/packages/flutter_tools/lib/src/commands/run.dart index f7d4aacc249..74fce6a9dae 100644 --- a/packages/flutter_tools/lib/src/commands/run.dart +++ b/packages/flutter_tools/lib/src/commands/run.dart @@ -289,8 +289,8 @@ class RunCommand extends RunCommandBase { dumpSkpOnShaderCompilation: argResults['dump-skp-on-shader-compilation'], observatoryPort: observatoryPort, verboseSystemLogs: argResults['verbose-system-logs'], - hostname: featureFlags.isWebEnabled ? argResults['hostname'] : '', - port: featureFlags.isWebEnabled ? argResults['port'] : '', + hostname: featureFlags.isWebEnabled ? argResults['web-hostname'] : '', + port: featureFlags.isWebEnabled ? argResults['web-port'] : '', ); } } diff --git a/packages/flutter_tools/lib/src/runner/flutter_command.dart b/packages/flutter_tools/lib/src/runner/flutter_command.dart index cf2724b1f91..55d05d0ae98 100644 --- a/packages/flutter_tools/lib/src/runner/flutter_command.dart +++ b/packages/flutter_tools/lib/src/runner/flutter_command.dart @@ -133,12 +133,12 @@ abstract class FlutterCommand extends Command { } void usesWebOptions({ bool hide = true }) { - argParser.addOption('hostname', + argParser.addOption('web-hostname', defaultsTo: 'localhost', help: 'The hostname to serve web application on.', hide: hide, ); - argParser.addOption('port', + argParser.addOption('web-port', defaultsTo: null, help: 'The host port to serve the web application from. If not provided, the tool ' 'will select a random open port on the host.',