development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-02 14:34:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Exclude abi key in local golden file testing (#148023)

Browse source 
Part of https://github.com/flutter/flutter/issues/148022
This commit is contained in:
Kate Lovett 2024-05-08 18:39:13 -05:00 committed by GitHub
parent 26030557b1
commit 00f40667c1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/flutter_goldens/lib/skia_client.dart
View file

@ -589,7 +589,8 @@ class SkiaGoldClient {
'WebRenderer' : webRenderer,
'CI' : 'luci',
'Platform' : platform.operatingSystem,
'Abi': abi.toString(),
// 'Abi': abi.toString(), workaround for https://g-issues.skia.org/issues/339508268
// Flutter tracking issue: https://github.com/flutter/flutter/issues/148022
'name' : testName,
'source_type' : 'flutter',
if (_isImpeller)

6
packages/flutter_goldens/test/flutter_goldens_test.dart
View file

@ -499,7 +499,7 @@ void main() {
expect(
skiaClient.getTraceID('flutter.golden.1'),
equals('1937c1c93610cc0122a86a83d5bd38a4'),
equals('ae18c7a6aa48e0685525dfe8fdf79003'),
);
});
@ -533,7 +533,7 @@ void main() {
expect(
skiaClient.getTraceID('flutter.golden.1'),
equals('bc44a50c01eb3bbaf72a80d76c1c2305'),
equals('e9d5c296c48e7126808520e9cc191243'),
);
});
@ -561,7 +561,7 @@ void main() {
);
expect(
skiaClient.getTraceID('flutter.golden.1'),
equals('8821f4896801fcdd7cd6d30f5a8e4284'),
equals('9968695b9ae78cdb77cbb2be621ca2d6'),
);
});