deno/tests/unit/make_temp_test.ts
Matt Mastracci 76ebf567e2
fix(ext/fs): make errors in tempfile creation clearer (#22498)
When using a prefix or suffix containing an invalid filename character,
it's not entirely clear where the errors come from. We make these errors
more consistent across platforms.

In addition, all permission prompts for tempfile and tempdir were
printing the same API name.

We also take the opportunity to make the tempfile random space larger by
2x (using a base32-encoded u64 rather than a hex-encoded u32).
2024-02-21 20:11:04 +00:00

180 lines
6.4 KiB
TypeScript

// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
import {
assert,
assertEquals,
assertRejects,
assertThrows,
} from "./test_util.ts";
Deno.test({ permissions: { write: true } }, function makeTempDirSyncSuccess() {
const dir1 = Deno.makeTempDirSync({ prefix: "hello", suffix: "world" });
const dir2 = Deno.makeTempDirSync({ prefix: "hello", suffix: "world" });
// Check that both dirs are different.
assert(dir1 !== dir2);
for (const dir of [dir1, dir2]) {
// Check that the prefix and suffix are applied.
const lastPart = dir.replace(/^.*[\\\/]/, "");
assert(lastPart.startsWith("hello"));
assert(lastPart.endsWith("world"));
}
// Check that the `dir` option works.
const dir3 = Deno.makeTempDirSync({ dir: dir1 });
assert(dir3.startsWith(dir1));
assert(/^[\\\/]/.test(dir3.slice(dir1.length)));
// Check that creating a temp dir inside a nonexisting directory fails.
assertThrows(() => {
Deno.makeTempDirSync({ dir: "/baddir" });
}, Deno.errors.NotFound);
});
Deno.test(
{ permissions: { read: true, write: true } },
function makeTempDirSyncMode() {
const path = Deno.makeTempDirSync();
const pathInfo = Deno.statSync(path);
if (Deno.build.os !== "windows") {
assertEquals(pathInfo.mode! & 0o777, 0o700 & ~Deno.umask());
}
},
);
Deno.test({ permissions: { write: false } }, function makeTempDirSyncPerm() {
// makeTempDirSync should require write permissions (for now).
assertThrows(() => {
Deno.makeTempDirSync({ dir: "/baddir" });
}, Deno.errors.PermissionDenied);
});
Deno.test(
{ permissions: { write: true } },
async function makeTempDirSuccess() {
const dir1 = await Deno.makeTempDir({ prefix: "hello", suffix: "world" });
const dir2 = await Deno.makeTempDir({ prefix: "hello", suffix: "world" });
// Check that both dirs are different.
assert(dir1 !== dir2);
for (const dir of [dir1, dir2]) {
// Check that the prefix and suffix are applied.
const lastPart = dir.replace(/^.*[\\\/]/, "");
assert(lastPart.startsWith("hello"));
assert(lastPart.endsWith("world"));
}
// Check that the `dir` option works.
const dir3 = await Deno.makeTempDir({ dir: dir1 });
assert(dir3.startsWith(dir1));
assert(/^[\\\/]/.test(dir3.slice(dir1.length)));
// Check that creating a temp dir inside a nonexisting directory fails.
await assertRejects(async () => {
await Deno.makeTempDir({ dir: "/baddir" });
}, Deno.errors.NotFound);
},
);
Deno.test(
{ permissions: { read: true, write: true } },
async function makeTempDirMode() {
const path = await Deno.makeTempDir();
const pathInfo = Deno.statSync(path);
if (Deno.build.os !== "windows") {
assertEquals(pathInfo.mode! & 0o777, 0o700 & ~Deno.umask());
}
},
);
Deno.test({ permissions: { write: true } }, function makeTempFileSyncSuccess() {
const file1 = Deno.makeTempFileSync({ prefix: "hello", suffix: "world" });
const file2 = Deno.makeTempFileSync({ prefix: "hello", suffix: "world" });
// Check that both dirs are different.
assert(file1 !== file2);
for (const dir of [file1, file2]) {
// Check that the prefix and suffix are applied.
const lastPart = dir.replace(/^.*[\\\/]/, "");
assert(lastPart.startsWith("hello"));
assert(lastPart.endsWith("world"));
}
// Check that the `dir` option works.
const dir = Deno.makeTempDirSync({ prefix: "tempdir" });
const file3 = Deno.makeTempFileSync({ dir });
assert(file3.startsWith(dir));
assert(/^[\\\/]/.test(file3.slice(dir.length)));
// Check that creating a temp file inside a nonexisting directory fails.
assertThrows(() => {
Deno.makeTempFileSync({ dir: "/baddir" });
}, Deno.errors.NotFound);
});
Deno.test(
{ permissions: { read: true, write: true } },
function makeTempFileSyncMode() {
const path = Deno.makeTempFileSync();
const pathInfo = Deno.statSync(path);
if (Deno.build.os !== "windows") {
assertEquals(pathInfo.mode! & 0o777, 0o600 & ~Deno.umask());
}
},
);
Deno.test({ permissions: { write: false } }, function makeTempFileSyncPerm() {
// makeTempFileSync should require write permissions (for now).
assertThrows(() => {
Deno.makeTempFileSync({ dir: "/baddir" });
}, Deno.errors.PermissionDenied);
});
Deno.test(
{ permissions: { write: true } },
async function makeTempFileSuccess() {
const file1 = await Deno.makeTempFile({ prefix: "hello", suffix: "world" });
const file2 = await Deno.makeTempFile({ prefix: "hello", suffix: "world" });
// Check that both dirs are different.
assert(file1 !== file2);
for (const dir of [file1, file2]) {
// Check that the prefix and suffix are applied.
const lastPart = dir.replace(/^.*[\\\/]/, "");
assert(lastPart.startsWith("hello"));
assert(lastPart.endsWith("world"));
}
// Check that the `dir` option works.
const dir = Deno.makeTempDirSync({ prefix: "tempdir" });
const file3 = await Deno.makeTempFile({ dir });
assert(file3.startsWith(dir));
assert(/^[\\\/]/.test(file3.slice(dir.length)));
// Check that creating a temp file inside a nonexisting directory fails.
await assertRejects(async () => {
await Deno.makeTempFile({ dir: "/baddir" });
}, Deno.errors.NotFound);
},
);
Deno.test(
{ permissions: { read: true, write: true } },
async function makeTempFileMode() {
const path = await Deno.makeTempFile();
const pathInfo = Deno.statSync(path);
if (Deno.build.os !== "windows") {
assertEquals(pathInfo.mode! & 0o777, 0o600 & ~Deno.umask());
}
},
);
Deno.test(
{ permissions: { read: true, write: true } },
function makeTempInvalidCharacter() {
// Various control and ASCII characters that are disallowed on all platforms
for (const invalid of ["\0", "*", "\x9f"]) {
assertThrows(() => Deno.makeTempFileSync({ prefix: invalid }));
assertThrows(() => Deno.makeTempDirSync({ prefix: invalid }));
assertThrows(() => Deno.makeTempFileSync({ suffix: invalid }));
assertThrows(() => Deno.makeTempDirSync({ suffix: invalid }));
}
// On Windows, files can't end with space or period
if (Deno.build.os === "windows") {
assertThrows(() => Deno.makeTempFileSync({ suffix: "." }));
assertThrows(() => Deno.makeTempFileSync({ suffix: " " }));
} else {
Deno.makeTempFileSync({ suffix: "." });
Deno.makeTempFileSync({ suffix: " " });
}
},
);