Nathan Whitaker 368eb9073b fix(napi): Read reference ownership before calling finalizer to avoid crash (#24203) ... Fixes #23493. What was happening here was that napi-rs was freeing the napi reference ([here](19e3488efc/crates/napi/src/bindgen_runtime/mod.rs (L62))) during its finalize callback (which we call [here](fb31eaa9ca/cli/napi/js_native_api.rs (L132))). We then were [reading the `ownership` field](fb31eaa9ca/cli/napi/js_native_api.rs (L136)) of that freed reference. For some reason on arm macs the freed memory gets zeroed, so the value of `ownership` was `0` when we read it (i.e. it was `ReferenceOwnership::Runtime`). We then freed it again (since we thought we owned it), causing the segfault.		2024-06-13 22:31:42 +00:00
..
src	fix(napi): Read reference ownership before calling finalizer to avoid crash (#24203)	2024-06-13 22:31:42 +00:00
tests	fix(napi): Read reference ownership before calling finalizer to avoid crash (#24203)	2024-06-13 22:31:42 +00:00
.gitignore	chore: move test_ffi and test_nap to tests/ [WIP] (#22394)	2024-02-12 13:46:50 -07:00
array_test.js	chore: move test_ffi and test_nap to tests/ [WIP] (#22394)	2024-02-12 13:46:50 -07:00
arraybuffer_test.js	chore: move test_ffi and test_nap to tests/ [WIP] (#22394)	2024-02-12 13:46:50 -07:00
async_test.js	chore: move test_ffi and test_nap to tests/ [WIP] (#22394)	2024-02-12 13:46:50 -07:00
bigint_test.js	chore: move test_ffi and test_nap to tests/ [WIP] (#22394)	2024-02-12 13:46:50 -07:00
build.rs	chore: move test_ffi and test_nap to tests/ [WIP] (#22394)	2024-02-12 13:46:50 -07:00
callback_test.js	chore: move test_ffi and test_nap to tests/ [WIP] (#22394)	2024-02-12 13:46:50 -07:00
Cargo.toml	chore: move test_ffi and test_nap to tests/ [WIP] (#22394)	2024-02-12 13:46:50 -07:00
cleanup_hook_test.js	chore: move test_ffi and test_nap to tests/ [WIP] (#22394)	2024-02-12 13:46:50 -07:00
coerce_test.js	chore: move test_ffi and test_nap to tests/ [WIP] (#22394)	2024-02-12 13:46:50 -07:00
common.js	chore: move test_ffi and test_nap to tests/ [WIP] (#22394)	2024-02-12 13:46:50 -07:00
date_test.js	chore: move test_ffi and test_nap to tests/ [WIP] (#22394)	2024-02-12 13:46:50 -07:00
env_test.js	chore: move test_ffi and test_nap to tests/ [WIP] (#22394)	2024-02-12 13:46:50 -07:00
error_test.js	chore: move test_ffi and test_nap to tests/ [WIP] (#22394)	2024-02-12 13:46:50 -07:00
init_test.js	fix: Rewrite Node-API (#24101)	2024-06-10 16:20:44 +00:00
make_callback_test.js	chore: move test_ffi and test_nap to tests/ [WIP] (#22394)	2024-02-12 13:46:50 -07:00
mem_test.js	chore: move test_ffi and test_nap to tests/ [WIP] (#22394)	2024-02-12 13:46:50 -07:00
module.c	chore: move test_ffi and test_nap to tests/ [WIP] (#22394)	2024-02-12 13:46:50 -07:00
numbers_test.js	chore: move test_ffi and test_nap to tests/ [WIP] (#22394)	2024-02-12 13:46:50 -07:00
object_test.js	fix(ext/node): napi_get_element and napi_set_element work with objects (#23713)	2024-05-06 21:22:50 +02:00
object_wrap_test.js	fix(napi): Read reference ownership before calling finalizer to avoid crash (#24203)	2024-06-13 22:31:42 +00:00
promise_test.js	chore: move test_ffi and test_nap to tests/ [WIP] (#22394)	2024-02-12 13:46:50 -07:00
properties_test.js	chore: move test_ffi and test_nap to tests/ [WIP] (#22394)	2024-02-12 13:46:50 -07:00
strings_test.js	chore: move test_ffi and test_nap to tests/ [WIP] (#22394)	2024-02-12 13:46:50 -07:00
symbol_test.js	chore: move test_ffi and test_nap to tests/ [WIP] (#22394)	2024-02-12 13:46:50 -07:00
typedarray_test.js	chore: move test_ffi and test_nap to tests/ [WIP] (#22394)	2024-02-12 13:46:50 -07:00