mirror of
https://github.com/denoland/deno
synced 2024-08-25 02:57:22 +00:00
![]() Deno v1.39 introduces `vm.runInNewContext`. This may cause problems when using `Object.prototype.isPrototypeOf` to check built-in types. ```js import vm from "node:vm"; const err = new Error(); const crossErr = vm.runInNewContext(`new Error()`); console.assert( !(crossErr instanceof Error) ); console.assert( Object.getPrototypeOf(err) !== Object.getPrototypeOf(crossErr) ); ``` This PR changes to check using internal slots solves them. --- current: ``` > import vm from "node:vm"; undefined > vm.runInNewContext(`new Error("message")`) Error {} > vm.runInNewContext(`new Date("2018-12-10T02:26:59.002Z")`) Date {} ``` this PR: ``` > import vm from "node:vm"; undefined > vm.runInNewContext(`new Error("message")`) Error: message at <anonymous>:1:1 > vm.runInNewContext(`new Date("2018-12-10T02:26:59.002Z")`) 2018-12-10T02:26:59.002Z ``` --------- Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com> |
||
---|---|---|
.. | ||
benches | ||
00_serve.js | ||
01_http.js | ||
Cargo.toml | ||
compressible.rs | ||
fly_accept_encoding.rs | ||
http_next.rs | ||
lib.rs | ||
network_buffered_stream.rs | ||
reader_stream.rs | ||
README.md | ||
request_body.rs | ||
request_properties.rs | ||
response_body.rs | ||
service.rs | ||
websocket_upgrade.rs |