Find a file
Aapo Alasuutari a4dfc6f955
fix(ext/ffi): Null buffer pointer value is inconsistent (#16625)
Currently, slow call path will always create a dangling pointer to
replace a null pointer when called with eg. a `new Uint8Array()`
parameter, which V8 initialises as a null pointer backed buffer.

However, the fast call path will never change the pointer value and will
thus expose a null pointer. Thus, it's possible that the pointer value
that a native call sees coming from Deno changes between two sequential
invocations of the same function with the exact same parameters.

Since null pointers can be quite important, and `Uint8Array` is the
chosen fast path for Deno FFI `"buffer"` parameters, I think it is
fairly important that the null pointer be properly exposed to the native
code. Thus this PR.

### `*mut c_void`
While here, I also changed the type of our pointer values to `*mut
c_void`. This is mainly due to JS buffers always being `*mut`, and
because we offer a way to turn a pointer into a JS `ArrayBuffer`
(`op_ffi_get_buf`) which is read-write. I'm not exactly sure which way
we should really go here, we have pointers that are definitely mut but
we also cannot assume all of our pointers are. So, do we go with the
maxima or the minima?

### `optimisedCall(new Uint8Array())`
V8 seems to have a bug where calling an optimised function with a newly
created empty `Uint8Array` (no argument or 0) will not see the data
pointer being null but instead it's some stable pointer, perhaps
pointing to some internal null-backing-store. The pointer value is also
an odd (not even) number, so it might specifically be a tagged pointer.

This will probably be an issue for some users, if they try to use eg.
`method(cstr("something"), new Uint8Array())` as a way to do a fast call
to `method` with a null pointer as the second parameter.

If instead of a `new Uint8Array()` the user instead uses some `const
NULL = new Uint8Array()` where the `NULL` buffer has been passed to a
slow call previously, then the fast call will properly see a null
pointer.

I'll take this up with some V8 engineers to see if this couldn't be
fixed.
2022-11-27 14:38:54 +00:00
.cargo chore: fix clippy warnings (#15944) 2022-09-19 10:25:03 +02:00
.devcontainer chore: update devcontainer configuration (#15751) 2022-09-03 02:21:41 +02:00
.github ci: increase timeout to 120 minutes (#16764) 2022-11-22 21:03:36 +01:00
bench_util feat(core): support initializing extensions with and without JS (#16789) 2022-11-27 00:58:23 +01:00
cli Revert "fix(ext/flash): graceful server startup/shutdown with unsettl… (#16839) 2022-11-27 04:50:14 +01:00
core feat(ops): fast calls for Wasm (#16776) 2022-11-27 19:24:28 +05:30
docs chore: move docs to separate repository 2021-07-20 16:25:36 +02:00
ext fix(ext/ffi): Null buffer pointer value is inconsistent (#16625) 2022-11-27 14:38:54 +00:00
ops feat(ops): fast calls for Wasm (#16776) 2022-11-27 19:24:28 +05:30
runtime feat(core): support initializing extensions with and without JS (#16789) 2022-11-27 00:58:23 +01:00
serde_v8 chore: forward v1.28.2 release commit to main (#16796) 2022-11-24 23:59:42 +01:00
test_ffi fix(ext/ffi): Null buffer pointer value is inconsistent (#16625) 2022-11-27 14:38:54 +00:00
test_napi chore: workspace inheritance (#16343) 2022-11-22 21:07:35 +01:00
test_util chore: workspace inheritance (#16343) 2022-11-22 21:07:35 +01:00
third_party@17fd391b8f fix(npm): support compiling on linux/aarch64 (#16208) 2022-10-10 07:59:31 +05:30
tools refactor: move generated_symbol_exports_list_* files to napi folder (#16822) 2022-11-25 18:49:02 -05:00
.dlint.json chore: enable camelcase rule in dlint (#12605) 2021-10-30 18:31:19 +02:00
.dprint.json refactor: move dts files, diagnostics.rs, and tsc.rs to tsc folder (#16820) 2022-11-25 18:29:48 -05:00
.editorconfig editorconfig: Don't insert final newline in .out files (#1686) 2019-02-07 11:31:49 -05:00
.gitattributes fix(test): support typechecking docs with CRLF line endings (#12748) 2021-11-15 09:58:04 -05:00
.gitignore feat(npm): implement Node API (#13633) 2022-10-05 19:36:44 +05:30
.gitmodules feat(ext/ffi): Implement FFI fast-call trampoline with Dynasmrt (#15305) 2022-09-07 12:23:56 +05:30
.rustfmt.toml chore: update copyright to 2022 (#13306) 2022-01-07 22:09:52 -05:00
Cargo.lock chore: update deno_doc (#16838) 2022-11-26 22:28:20 +00:00
Cargo.toml chore: update rusty_v8 to 0.56.1 (#16835) 2022-11-26 20:11:27 +01:00
CODE_OF_CONDUCT.md fix(tools): prettier formatting (#6206) 2020-06-09 17:50:41 +02:00
LICENSE.md chore: update copyright to 2022 (#13306) 2022-01-07 22:09:52 -05:00
README.md docs: use irm instead of iwr -useb (#15474) 2022-08-15 10:05:29 -04:00
Releases.md chore: forward v1.28.2 release commit to main (#16796) 2022-11-24 23:59:42 +01:00
rust-toolchain.toml chore: use Rust 1.65.0 (#16688) 2022-11-18 02:59:10 +01:00
SECURITY.md chore: change e-mail address for security issues (#15239) 2022-07-18 16:55:05 -07:00

Deno

Build Status - Cirrus Twitter handle Discord Chat

the deno mascot dinosaur standing in the rain

Deno is a simple, modern and secure runtime for JavaScript and TypeScript that uses V8 and is built in Rust.

Features

  • Secure by default. No file, network, or environment access, unless explicitly enabled.
  • Supports TypeScript out of the box.
  • Ships only a single executable file.
  • Built-in utilities.
  • Set of reviewed standard modules that are guaranteed to work with Deno.

Install

Shell (Mac, Linux):

curl -fsSL https://deno.land/install.sh | sh

PowerShell (Windows):

irm https://deno.land/install.ps1 | iex

Homebrew (Mac):

brew install deno

Chocolatey (Windows):

choco install deno

Scoop (Windows):

scoop install deno

Build and install from source using Cargo:

cargo install deno --locked

See deno_install and releases for other options.

Getting Started

Try running a simple program:

deno run https://deno.land/std/examples/welcome.ts

Or a more complex one:

const listener = Deno.listen({ port: 8000 });
console.log("http://localhost:8000/");

for await (const conn of listener) {
  serve(conn);
}

async function serve(conn: Deno.Conn) {
  for await (const { respondWith } of Deno.serveHttp(conn)) {
    respondWith(new Response("Hello world"));
  }
}

You can find a deeper introduction, examples, and environment setup guides in the manual.

The complete API reference is available at the runtime documentation.

Contributing

We appreciate your help!

To contribute, please read our contributing instructions.