development/deno
development/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno synced 2024-08-27 03:50:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: improve http client builder error message (#9380)

Browse source 
Include the lower-level error message in the generic error message.

No test because I can't actually make it fail by passing it bad PEM.
I checked and `reqwest::Certificate::from_pem()` always returns `Ok()`.

Fixes #9364.
This commit is contained in:
Ben Noordhuis 2021-02-03 11:40:43 +01:00 committed by GitHub
parent 3f6483e501
commit fb358380c0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
cli/http_util.rs
View file

@ -34,8 +34,9 @@ pub fn create_http_client(
builder
.build()
.map_err(|_| generic_error("Unable to build http client"))
.map_err(|e| generic_error(format!("Unable to build http client: {}", e)))
}
/// Construct the next uri based on base uri and location header fragment
/// See <https://tools.ietf.org/html/rfc3986#section-4.2>
fn resolve_url_from_location(base_url: &Url, location: &str) -> Url {

3
op_crates/fetch/lib.rs
View file

@ -3,6 +3,7 @@
#![deny(warnings)]
use deno_core::error::bad_resource_id;
use deno_core::error::generic_error;
use deno_core::error::type_error;
use deno_core::error::AnyError;
use deno_core::futures::Future;
@ -433,5 +434,5 @@ fn create_http_client(
}
builder
.build()
.map_err(|_| deno_core::error::generic_error("Unable to build http client"))
.map_err(|e| generic_error(format!("Unable to build http client: {}", e)))
}

2
runtime/http_util.rs
View file

@ -28,7 +28,7 @@ pub fn create_http_client(
builder
.build()
.map_err(|_| generic_error("Unable to build http client"))
.map_err(|e| generic_error(format!("Unable to build http client: {}", e)))
}
#[cfg(test)]