development/deno
development/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno synced 2024-08-27 03:50:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: set removal version for --jobs flag (#22028)

Browse source 
For removal in Deno v2. I'm uncertain of the output format but used
#21452 as a guide.

Towards #22021
This commit is contained in:
Asher Gomez 2024-01-23 12:19:12 +11:00 committed by GitHub
parent 71551c80a1
commit f2b0424df6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
cli/args/flags.rs
View file

@ -2181,7 +2181,7 @@ Directory arguments are expanded to all contained files matching the glob
Arg::new("jobs")
.short('j')
.long("jobs")
.help("deprecated: Number of parallel workers, defaults to number of available CPUs when no value is provided. Defaults to 1 when the option is not present.")
.help("deprecated: The `--jobs` flag is deprecated and will be removed in Deno 2.0. Use the `--parallel` flag with possibly the `DENO_JOBS` environment variable instead.")
.hide(true)
.num_args(0..=1)
.value_parser(value_parser!(NonZeroUsize)),
@ -3697,8 +3697,8 @@ fn test_parse(flags: &mut Flags, matches: &mut ArgMatches) {
// deprecated though so it's not worth changing the code to use the log
// crate here and this is only done for testing anyway.
eprintln!(
"{}",
crate::colors::yellow("Warning: --jobs flag is deprecated. Use the --parallel flag with possibly the 'DENO_JOBS' environment variable."),
"⚠️ {}",
crate::colors::yellow("The `--jobs` flag is deprecated and will be removed in Deno 2.0.\nUse the `--parallel` flag with possibly the `DENO_JOBS` environment variable instead.\nLearn more at: https://docs.deno.com/runtime/manual/basics/env_variables"),
);
if let Some(value) = matches.remove_one::<NonZeroUsize>("jobs") {
Some(value)

4
cli/tests/testdata/test/short-pass-jobs-flag-warning.out vendored
View file

@ -1,4 +1,6 @@
Warning: --jobs flag is deprecated. Use the --parallel flag with possibly the 'DENO_JOBS' environment variable.
⚠️ The `--jobs` flag is deprecated and will be removed in Deno 2.0.
Use the `--parallel` flag with possibly the `DENO_JOBS` environment variable instead.
Learn more at: https://docs.deno.com/runtime/manual/basics/env_variables
Check [WILDCARD]/test/short-pass.ts
./test/short-pass.ts => test ... ok ([WILDCARD])