development/deno
development/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno synced 2024-10-02 14:23:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ext/node): handle null in stdio array (#23048)

Browse source 
Fixes https://github.com/denoland/deno/issues/23045
This commit is contained in:
Divy Srivastava 2024-03-24 11:25:53 +05:30 committed by GitHub
parent c940205353
commit ec9342f95a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 23 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
ext/node/polyfills/internal/child_process.ts
View file

@ -503,11 +503,20 @@ function normalizeStdioOption(
if (Array.isArray(stdio)) {
// `[0, 1, 2]` is equivalent to `"inherit"`
if (
stdio.length === 3 && stdio[0] === 0 && stdio[1] === 1 && stdio[2] === 2
stdio.length === 3 &&
(stdio[0] === 0 && stdio[1] === 1 && stdio[2] === 2)
) {
return ["inherit", "inherit", "inherit"];
}
// `[null, null, null]` is equivalent to `"pipe"
if (
stdio.length === 3 &&
stdio[0] === null || stdio[1] === null || stdio[2] === null
) {
return ["pipe", "pipe", "pipe"];
}
// At least 3 stdio must be created to match node
while (stdio.length < 3) {
ArrayPrototypePush(stdio, undefined);

13
tests/unit_node/child_process_test.ts
View file

@ -810,3 +810,16 @@ Deno.test(async function spawnCommandNotFoundErrno() {
});
await promise;
});
// https://github.com/denoland/deno/issues/23045
Deno.test(function spawnCommandNullStdioArray() {
const ret = spawnSync(
`"${Deno.execPath()}" eval "console.log('hello');console.error('world')"`,
{
stdio: [null, null, null],
shell: true,
},
);
assertEquals(ret.status, 0);
});