mirror of
https://github.com/denoland/deno
synced 2024-08-27 12:00:17 +00:00
fix: don't panic in test and bench if ops not available (#23055)
Fixes regression introduced in https://github.com/denoland/deno/pull/22112 that removed checks if `Deno.test` or `Deno.bench` are not used in respective subcommands. Closes https://github.com/denoland/deno/issues/23041
This commit is contained in:
parent
d263c632e3
commit
d043dd86f7
|
@ -47,6 +47,11 @@ function bench(
|
||||||
optionsOrFn,
|
optionsOrFn,
|
||||||
maybeFn,
|
maybeFn,
|
||||||
) {
|
) {
|
||||||
|
// No-op if we're not running in `deno bench` subcommand.
|
||||||
|
if (typeof op_register_bench !== "function") {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
if (!registeredWarmupBench) {
|
if (!registeredWarmupBench) {
|
||||||
registeredWarmupBench = true;
|
registeredWarmupBench = true;
|
||||||
const warmupBenchDesc = {
|
const warmupBenchDesc = {
|
||||||
|
|
|
@ -198,6 +198,11 @@ function testInner(
|
||||||
maybeFn,
|
maybeFn,
|
||||||
overrides = {},
|
overrides = {},
|
||||||
) {
|
) {
|
||||||
|
// No-op if we're not running in `deno test` subcommand.
|
||||||
|
if (typeof op_register_test !== "function") {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
let testDesc;
|
let testDesc;
|
||||||
const defaults = {
|
const defaults = {
|
||||||
ignore: false,
|
ignore: false,
|
||||||
|
|
5
tests/specs/bench/test_and_bench/__test__.jsonc
Normal file
5
tests/specs/bench/test_and_bench/__test__.jsonc
Normal file
|
@ -0,0 +1,5 @@
|
||||||
|
// Regression test for https://github.com/denoland/deno/issues/23041
|
||||||
|
{
|
||||||
|
"args": "bench main.js",
|
||||||
|
"output": "main.out"
|
||||||
|
}
|
3
tests/specs/bench/test_and_bench/main.js
Normal file
3
tests/specs/bench/test_and_bench/main.js
Normal file
|
@ -0,0 +1,3 @@
|
||||||
|
Deno.test("test", () => {});
|
||||||
|
|
||||||
|
Deno.bench("bench", () => {});
|
3
tests/specs/bench/test_and_bench/main.out
Normal file
3
tests/specs/bench/test_and_bench/main.out
Normal file
|
@ -0,0 +1,3 @@
|
||||||
|
[WILDCARD]
|
||||||
|
[WILDCARD]main.js
|
||||||
|
benchmark[WILDCARD]
|
5
tests/specs/test/test_and_bench/__test__.jsonc
Normal file
5
tests/specs/test/test_and_bench/__test__.jsonc
Normal file
|
@ -0,0 +1,5 @@
|
||||||
|
// Regression test for https://github.com/denoland/deno/issues/23041
|
||||||
|
{
|
||||||
|
"args": "test main.js",
|
||||||
|
"output": "main.out"
|
||||||
|
}
|
3
tests/specs/test/test_and_bench/main.js
Normal file
3
tests/specs/test/test_and_bench/main.js
Normal file
|
@ -0,0 +1,3 @@
|
||||||
|
Deno.test("test", () => {});
|
||||||
|
|
||||||
|
Deno.bench("bench", () => {});
|
5
tests/specs/test/test_and_bench/main.out
Normal file
5
tests/specs/test/test_and_bench/main.out
Normal file
|
@ -0,0 +1,5 @@
|
||||||
|
running 1 test from ./main.js
|
||||||
|
test ... ok ([WILDCARD])
|
||||||
|
|
||||||
|
ok | 1 passed | 0 failed ([WILDCARD])
|
||||||
|
|
Loading…
Reference in a new issue