fix: don't panic in test and bench if ops not available (#23055)

Fixes regression introduced in
https://github.com/denoland/deno/pull/22112 that
removed checks if `Deno.test` or `Deno.bench` are not used in respective
subcommands.

Closes https://github.com/denoland/deno/issues/23041
This commit is contained in:
Bartek Iwańczuk 2024-03-24 23:16:45 +00:00 committed by GitHub
parent d263c632e3
commit d043dd86f7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 34 additions and 0 deletions

View file

@ -47,6 +47,11 @@ function bench(
optionsOrFn, optionsOrFn,
maybeFn, maybeFn,
) { ) {
// No-op if we're not running in `deno bench` subcommand.
if (typeof op_register_bench !== "function") {
return;
}
if (!registeredWarmupBench) { if (!registeredWarmupBench) {
registeredWarmupBench = true; registeredWarmupBench = true;
const warmupBenchDesc = { const warmupBenchDesc = {

View file

@ -198,6 +198,11 @@ function testInner(
maybeFn, maybeFn,
overrides = {}, overrides = {},
) { ) {
// No-op if we're not running in `deno test` subcommand.
if (typeof op_register_test !== "function") {
return;
}
let testDesc; let testDesc;
const defaults = { const defaults = {
ignore: false, ignore: false,

View file

@ -0,0 +1,5 @@
// Regression test for https://github.com/denoland/deno/issues/23041
{
"args": "bench main.js",
"output": "main.out"
}

View file

@ -0,0 +1,3 @@
Deno.test("test", () => {});
Deno.bench("bench", () => {});

View file

@ -0,0 +1,3 @@
[WILDCARD]
[WILDCARD]main.js
benchmark[WILDCARD]

View file

@ -0,0 +1,5 @@
// Regression test for https://github.com/denoland/deno/issues/23041
{
"args": "test main.js",
"output": "main.out"
}

View file

@ -0,0 +1,3 @@
Deno.test("test", () => {});
Deno.bench("bench", () => {});

View file

@ -0,0 +1,5 @@
running 1 test from ./main.js
test ... ok ([WILDCARD])
ok | 1 passed | 0 failed ([WILDCARD])