development/deno
development/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno synced 2024-07-07 20:06:37 +00:00
Code Issues Projects Releases Wiki Activity

fix(install): forward granular --unstable-* flags (#22164)

Browse Source 
Closes https://github.com/denoland/deno/issues/22154
This commit is contained in:
Bartek Iwańczuk 2024-02-01 04:46:37 +01:00 committed by GitHub
parent 6512be458f
commit cfb57b1855
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 71 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

71
cli/tools/installer.rs
View File

@ -382,6 +382,10 @@ async fn resolve_shim_data(
executable_args.push("--unstable".to_string());
}
for feature in &flags.unstable_config.features {
executable_args.push(format!("--unstable-{}", feature));
}
if flags.no_remote {
executable_args.push("--no-remote".to_string());
}
@ -706,6 +710,73 @@ mod tests {
);
}
#[tokio::test]
async fn install_unstable_legacy() {
let shim_data = resolve_shim_data(
&Flags {
unstable_config: UnstableConfig {
legacy_flag_enabled: true,
..Default::default()
},
..Default::default()
},
&InstallFlags {
module_url: "http://localhost:4545/echo_server.ts".to_string(),
args: vec![],
name: None,
root: Some(env::temp_dir().to_string_lossy().to_string()),
force: false,
},
)
.await
.unwrap();
assert_eq!(shim_data.name, "echo_server");
assert_eq!(
shim_data.args,
vec![
"run",
"--unstable",
"--no-config",
"http://localhost:4545/echo_server.ts",
]
);
}
#[tokio::test]
async fn install_unstable_features() {
let shim_data = resolve_shim_data(
&Flags {
unstable_config: UnstableConfig {
features: vec!["kv".to_string(), "cron".to_string()],
..Default::default()
},
..Default::default()
},
&InstallFlags {
module_url: "http://localhost:4545/echo_server.ts".to_string(),
args: vec![],
name: None,
root: Some(env::temp_dir().to_string_lossy().to_string()),
force: false,
},
)
.await
.unwrap();
assert_eq!(shim_data.name, "echo_server");
assert_eq!(
shim_data.args,
vec![
"run",
"--unstable-kv",
"--unstable-cron",
"--no-config",
"http://localhost:4545/echo_server.ts",
]
);
}
#[tokio::test]
async fn install_inferred_name_from_parent() {
let shim_data = resolve_shim_data(