development/deno
development/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno synced 2024-09-17 23:22:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Use # to denote line number in stack traces (#6114)

Browse source 
This makes the URLs in stack traces actual URLs to the files.
Before: https://deno.land/std/testing/asserts.ts:138:11
After: https://deno.land/std/testing/asserts.ts#138:11
This commit is contained in:
Andrew Mitchell 2020-06-05 12:01:02 +00:00 committed by GitHub
parent 9a783ae4e6
commit c4c6a8dae4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
19 changed files with 56 additions and 56 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cli/js/error_stack.ts
View file

@ -119,7 +119,7 @@ function getFileLocation(callSite: CallSite, isInternal = false): string {
const lineNumber = callSite.getLineNumber(); const lineNumber = callSite.getLineNumber();
if (lineNumber != null) { if (lineNumber != null) {
result += `${black(":")}${yellow(lineNumber.toString())}`; result += `${black("#")}${yellow(lineNumber.toString())}`;
const columnNumber = callSite.getColumnNumber(); const columnNumber = callSite.getColumnNumber();
if (columnNumber != null) { if (columnNumber != null) {

12
cli/tests/020_json_modules.ts.out
View file

@ -1,9 +1,9 @@
[WILDCARD] [WILDCARD]
error: Uncaught TypeError: Cannot resolve extension for "[WILDCARD]config.json" with mediaType "Json". error: Uncaught TypeError: Cannot resolve extension for "[WILDCARD]config.json" with mediaType "Json".
at getExtension ($deno$/compiler.ts:[WILDCARD]) at getExtension ($deno$/compiler.ts#[WILDCARD])
at new SourceFile ($deno$/compiler.ts:[WILDCARD]) at new SourceFile ($deno$/compiler.ts#[WILDCARD])
at Function.addToCache ($deno$/compiler.ts:[WILDCARD]) at Function.addToCache ($deno$/compiler.ts#[WILDCARD])
at buildSourceFileCache ($deno$/compiler.ts:[WILDCARD]) at buildSourceFileCache ($deno$/compiler.ts#[WILDCARD])
at compile ($deno$/compiler.ts:[WILDCARD]) at compile ($deno$/compiler.ts#[WILDCARD])
at tsCompilerOnMessage ($deno$/compiler.ts:[WILDCARD]) at tsCompilerOnMessage ($deno$/compiler.ts#[WILDCARD])
[WILDCARD] [WILDCARD]

6
cli/tests/044_bad_resource.ts.out
View file

@ -1,4 +1,4 @@
[WILDCARD]error: Uncaught BadResource: Bad resource ID [WILDCARD]error: Uncaught BadResource: Bad resource ID
at unwrapResponse ([WILDCARD]dispatch_json.ts:[WILDCARD]) at unwrapResponse ([WILDCARD]dispatch_json.ts#[WILDCARD])
at Object.sendAsync ([WILDCARD]dispatch_json.ts:[WILDCARD]) at Object.sendAsync ([WILDCARD]dispatch_json.ts#[WILDCARD])
at async main ([WILDCARD]tests/044_bad_resource.ts:[WILDCARD]) at async main ([WILDCARD]tests/044_bad_resource.ts#[WILDCARD])

4
cli/tests/async_error.ts.out
View file

@ -4,5 +4,5 @@ world
error: Uncaught Error: error error: Uncaught Error: error
throw Error("error"); throw Error("error");
^ ^
at foo ([WILDCARD]tests/async_error.ts:5:9) at foo ([WILDCARD]tests/async_error.ts#5:9)
at [WILDCARD]tests/async_error.ts:8:1 at [WILDCARD]tests/async_error.ts#8:1

6
cli/tests/error_001.ts.out
View file

@ -1,6 +1,6 @@
[WILDCARD]error: Uncaught Error: bad [WILDCARD]error: Uncaught Error: bad
throw Error("bad"); throw Error("bad");
^ ^
at foo ([WILDCARD]tests/error_001.ts:2:9) at foo ([WILDCARD]tests/error_001.ts#2:9)
at bar ([WILDCARD]tests/error_001.ts:6:3) at bar ([WILDCARD]tests/error_001.ts#6:3)
at [WILDCARD]tests/error_001.ts:9:1 at [WILDCARD]tests/error_001.ts#9:1

6
cli/tests/error_002.ts.out
View file

@ -1,6 +1,6 @@
[WILDCARD]error: Uncaught Error: exception from mod1 [WILDCARD]error: Uncaught Error: exception from mod1
throw Error("exception from mod1"); throw Error("exception from mod1");
^ ^
at throwsError ([WILDCARD]tests/subdir/mod1.ts:16:9) at throwsError ([WILDCARD]tests/subdir/mod1.ts#16:9)
at foo ([WILDCARD]tests/error_002.ts:4:3) at foo ([WILDCARD]tests/error_002.ts#4:3)
at [WILDCARD]tests/error_002.ts:7:1 at [WILDCARD]tests/error_002.ts#7:1

2
cli/tests/error_008_checkjs.js.out
View file

@ -1,4 +1,4 @@
[WILDCARD]error: Uncaught ReferenceError: consol is not defined [WILDCARD]error: Uncaught ReferenceError: consol is not defined
consol.log("hello world!"); consol.log("hello world!");
^ ^
at [WILDCARD]tests/error_008_checkjs.js:2:1 at [WILDCARD]tests/error_008_checkjs.js#2:1

4
cli/tests/error_014_catch_dynamic_import_error.js.out
View file

@ -6,7 +6,7 @@ TypeError: relative import path "does not exist either" not prefixed with / or .
Caught error thrown by dynamically imported module. Caught error thrown by dynamically imported module.
Error: An error Error: An error
at file:///[WILDCARD]tests/subdir/throws.js:5:7 at file:///[WILDCARD]tests/subdir/throws.js#5:7
Caught error thrown indirectly by dynamically imported module. Caught error thrown indirectly by dynamically imported module.
Error: An error Error: An error
at file:///[WILDCARD]tests/subdir/throws.js:5:7 at file:///[WILDCARD]tests/subdir/throws.js#5:7

2
cli/tests/error_018_hide_long_source_js.js.out
View file

@ -1,2 +1,2 @@
error: Uncaught TypeError: Cannot read property 'a' of undefined error: Uncaught TypeError: Cannot read property 'a' of undefined
at file:///[WILDCARD]cli/tests/error_018_hide_long_source_js.js:2:206 at file:///[WILDCARD]cli/tests/error_018_hide_long_source_js.js#2:206

8
cli/tests/error_019_stack_function.ts.out
View file

@ -1,6 +1,6 @@
[WILDCARD]Error: function [WILDCARD]Error: function
at foo ([WILDCARD]tests/error_019_stack_function.ts:[WILDCARD]) at foo ([WILDCARD]tests/error_019_stack_function.ts#[WILDCARD])
at [WILDCARD]tests/error_019_stack_function.ts:[WILDCARD] at [WILDCARD]tests/error_019_stack_function.ts#[WILDCARD]
error: Uncaught Error: function error: Uncaught Error: function
at foo ([WILDCARD]tests/error_019_stack_function.ts:[WILDCARD]) at foo ([WILDCARD]tests/error_019_stack_function.ts#[WILDCARD])
at [WILDCARD]tests/error_019_stack_function.ts:[WILDCARD] at [WILDCARD]tests/error_019_stack_function.ts#[WILDCARD]

8
cli/tests/error_020_stack_constructor.ts.out
View file

@ -1,6 +1,6 @@
[WILDCARD]Error: constructor [WILDCARD]Error: constructor
at new A ([WILDCARD]tests/error_020_stack_constructor.ts:[WILDCARD]) at new A ([WILDCARD]tests/error_020_stack_constructor.ts#[WILDCARD])
at [WILDCARD]tests/error_020_stack_constructor.ts:[WILDCARD] at [WILDCARD]tests/error_020_stack_constructor.ts#[WILDCARD]
error: Uncaught Error: constructor error: Uncaught Error: constructor
at new A ([WILDCARD]tests/error_020_stack_constructor.ts:[WILDCARD]) at new A ([WILDCARD]tests/error_020_stack_constructor.ts#[WILDCARD])
at [WILDCARD]tests/error_020_stack_constructor.ts:[WILDCARD] at [WILDCARD]tests/error_020_stack_constructor.ts#[WILDCARD]

8
cli/tests/error_021_stack_method.ts.out
View file

@ -1,6 +1,6 @@
[WILDCARD]Error: method [WILDCARD]Error: method
at A.m ([WILDCARD]tests/error_021_stack_method.ts:[WILDCARD]) at A.m ([WILDCARD]tests/error_021_stack_method.ts#[WILDCARD])
at [WILDCARD]tests/error_021_stack_method.ts:[WILDCARD] at [WILDCARD]tests/error_021_stack_method.ts#[WILDCARD]
error: Uncaught Error: method error: Uncaught Error: method
at A.m ([WILDCARD]tests/error_021_stack_method.ts:[WILDCARD]) at A.m ([WILDCARD]tests/error_021_stack_method.ts#[WILDCARD])
at [WILDCARD]tests/error_021_stack_method.ts:[WILDCARD] at [WILDCARD]tests/error_021_stack_method.ts#[WILDCARD]

4
cli/tests/error_022_stack_custom_error.ts.out
View file

@ -1,4 +1,4 @@
[WILDCARD]CustomError: custom error [WILDCARD]CustomError: custom error
at [WILDCARD]tests/error_022_stack_custom_error.ts:[WILDCARD] at [WILDCARD]tests/error_022_stack_custom_error.ts#[WILDCARD]
error: Uncaught CustomError: custom error error: Uncaught CustomError: custom error
at [WILDCARD]tests/error_022_stack_custom_error.ts:[WILDCARD] at [WILDCARD]tests/error_022_stack_custom_error.ts#[WILDCARD]

12
cli/tests/error_023_stack_async.ts.out
View file

@ -1,8 +1,8 @@
[WILDCARD]Error: async [WILDCARD]Error: async
at [WILDCARD]tests/error_023_stack_async.ts:[WILDCARD] at [WILDCARD]tests/error_023_stack_async.ts#[WILDCARD]
at async [WILDCARD]tests/error_023_stack_async.ts:[WILDCARD] at async [WILDCARD]tests/error_023_stack_async.ts#[WILDCARD]
at async [WILDCARD]tests/error_023_stack_async.ts:[WILDCARD] at async [WILDCARD]tests/error_023_stack_async.ts#[WILDCARD]
error: Uncaught Error: async error: Uncaught Error: async
at [WILDCARD]tests/error_023_stack_async.ts:[WILDCARD] at [WILDCARD]tests/error_023_stack_async.ts#[WILDCARD]
at async [WILDCARD]tests/error_023_stack_async.ts:[WILDCARD] at async [WILDCARD]tests/error_023_stack_async.ts#[WILDCARD]
at async [WILDCARD]tests/error_023_stack_async.ts:[WILDCARD] at async [WILDCARD]tests/error_023_stack_async.ts#[WILDCARD]

8
cli/tests/error_024_stack_promise_all.ts.out
View file

@ -1,8 +1,8 @@
[WILDCARD]Error: Promise.all() [WILDCARD]Error: Promise.all()
at [WILDCARD]tests/error_024_stack_promise_all.ts:[WILDCARD] at [WILDCARD]tests/error_024_stack_promise_all.ts#[WILDCARD]
at async Promise.all (index 0) at async Promise.all (index 0)
at async [WILDCARD]tests/error_024_stack_promise_all.ts:[WILDCARD] at async [WILDCARD]tests/error_024_stack_promise_all.ts#[WILDCARD]
error: Uncaught Error: Promise.all() error: Uncaught Error: Promise.all()
at [WILDCARD]tests/error_024_stack_promise_all.ts:[WILDCARD] at [WILDCARD]tests/error_024_stack_promise_all.ts#[WILDCARD]
at async Promise.all (index 0) at async Promise.all (index 0)
at async [WILDCARD]tests/error_024_stack_promise_all.ts:[WILDCARD] at async [WILDCARD]tests/error_024_stack_promise_all.ts#[WILDCARD]

6
cli/tests/error_025_tab_indent.out
View file

@ -1,6 +1,6 @@
[WILDCARD]error: Uncaught Error: bad [WILDCARD]error: Uncaught Error: bad
throw Error("bad"); throw Error("bad");
^ ^
at foo ([WILDCARD]tests/error_025_tab_indent:2:8) at foo ([WILDCARD]tests/error_025_tab_indent#2:8)
at bar ([WILDCARD]tests/error_025_tab_indent:6:2) at bar ([WILDCARD]tests/error_025_tab_indent#6:2)
at [WILDCARD]tests/error_025_tab_indent:9:1 at [WILDCARD]tests/error_025_tab_indent#9:1

6
cli/tests/unit/dispatch_json_test.ts
View file

@ -2,9 +2,9 @@ import { assert, unitTest, assertMatch, unreachable } from "./test_util.ts";
const openErrorStackPattern = new RegExp( const openErrorStackPattern = new RegExp(
`^.* `^.*
at unwrapResponse \\(.*dispatch_json\\.ts:.*\\) at unwrapResponse \\(.*dispatch_json\\.ts#.*\\)
at Object.sendAsync \\(.*dispatch_json\\.ts:.*\\) at Object.sendAsync \\(.*dispatch_json\\.ts#.*\\)
at async Object\\.open \\(.*files\\.ts:.*\\).*$`, at async Object\\.open \\(.*files\\.ts#.*\\).*$`,
"ms" "ms"
); );

6
cli/tests/unit/dispatch_minimal_test.ts
View file

@ -8,9 +8,9 @@ import {
const readErrorStackPattern = new RegExp( const readErrorStackPattern = new RegExp(
`^.* `^.*
at unwrapResponse \\(.*dispatch_minimal\\.ts:.*\\) at unwrapResponse \\(.*dispatch_minimal\\.ts#.*\\)
at Object.sendAsyncMinimal \\(.*dispatch_minimal\\.ts:.*\\) at Object.sendAsyncMinimal \\(.*dispatch_minimal\\.ts#.*\\)
at async Object\\.read \\(.*io\\.ts:.*\\).*$`, at async Object\\.read \\(.*io\\.ts#.*\\).*$`,
"ms" "ms"
); );

2
cli/tests/unit/error_stack_test.ts
View file

@ -93,7 +93,7 @@ unitTest(function prepareStackTrace(): void {
getMockCallSite("CLI_SNAPSHOT.js", 23, 0), getMockCallSite("CLI_SNAPSHOT.js", 23, 0),
]); ]);
assert(result.startsWith("Error: foo\n")); assert(result.startsWith("Error: foo\n"));
assert(result.includes(".ts:"), "should remap to something in 'js/'"); assert(result.includes(".ts#"), "should remap to something in 'js/'");
}); });
unitTest(function captureStackTrace(): void { unitTest(function captureStackTrace(): void {