mirror of
https://github.com/denoland/deno
synced 2024-10-05 23:59:24 +00:00
perf(lsp): Avoid passing struct into op_resolve (#23452)
Going through serde_v8 is slow, so just pass the args separately. `op_resolve` is especially hot, so any speedups are good.
This commit is contained in:
parent
f4b5eec52e
commit
b5ce9cda0d
|
@ -4058,9 +4058,10 @@ fn op_release(
|
||||||
#[serde]
|
#[serde]
|
||||||
fn op_resolve(
|
fn op_resolve(
|
||||||
state: &mut OpState,
|
state: &mut OpState,
|
||||||
#[serde] args: ResolveArgs,
|
#[string] base: String,
|
||||||
|
#[serde] specifiers: Vec<String>,
|
||||||
) -> Result<Vec<Option<(String, String)>>, AnyError> {
|
) -> Result<Vec<Option<(String, String)>>, AnyError> {
|
||||||
op_resolve_inner(state, args)
|
op_resolve_inner(state, ResolveArgs { base, specifiers })
|
||||||
}
|
}
|
||||||
|
|
||||||
#[inline]
|
#[inline]
|
||||||
|
|
|
@ -681,7 +681,8 @@ delete Object.prototype.__proto__;
|
||||||
debug(`host.writeFile("${fileName}")`);
|
debug(`host.writeFile("${fileName}")`);
|
||||||
}
|
}
|
||||||
return ops.op_emit(
|
return ops.op_emit(
|
||||||
{ fileName, data },
|
data,
|
||||||
|
fileName,
|
||||||
);
|
);
|
||||||
},
|
},
|
||||||
getCurrentDirectory() {
|
getCurrentDirectory() {
|
||||||
|
@ -717,10 +718,10 @@ delete Object.prototype.__proto__;
|
||||||
: arg;
|
: arg;
|
||||||
if (fileReference.fileName.startsWith("npm:")) {
|
if (fileReference.fileName.startsWith("npm:")) {
|
||||||
/** @type {[string, ts.Extension] | undefined} */
|
/** @type {[string, ts.Extension] | undefined} */
|
||||||
const resolved = ops.op_resolve({
|
const resolved = ops.op_resolve(
|
||||||
specifiers: [fileReference.fileName],
|
containingFilePath,
|
||||||
base: containingFilePath,
|
[fileReference.fileName],
|
||||||
})?.[0];
|
)?.[0];
|
||||||
if (resolved) {
|
if (resolved) {
|
||||||
isCjsCache.maybeAdd(resolved);
|
isCjsCache.maybeAdd(resolved);
|
||||||
return {
|
return {
|
||||||
|
@ -750,10 +751,10 @@ delete Object.prototype.__proto__;
|
||||||
debug(` specifiers: ${specifiers.join(", ")}`);
|
debug(` specifiers: ${specifiers.join(", ")}`);
|
||||||
}
|
}
|
||||||
/** @type {Array<[string, ts.Extension] | undefined>} */
|
/** @type {Array<[string, ts.Extension] | undefined>} */
|
||||||
const resolved = ops.op_resolve({
|
const resolved = ops.op_resolve(
|
||||||
specifiers,
|
|
||||||
base,
|
base,
|
||||||
});
|
specifiers,
|
||||||
|
);
|
||||||
if (resolved) {
|
if (resolved) {
|
||||||
const result = resolved.map((item) => {
|
const result = resolved.map((item) => {
|
||||||
if (item) {
|
if (item) {
|
||||||
|
|
|
@ -412,9 +412,13 @@ struct EmitArgs {
|
||||||
file_name: String,
|
file_name: String,
|
||||||
}
|
}
|
||||||
|
|
||||||
#[op2]
|
#[op2(fast)]
|
||||||
fn op_emit(state: &mut OpState, #[serde] args: EmitArgs) -> bool {
|
fn op_emit(
|
||||||
op_emit_inner(state, args)
|
state: &mut OpState,
|
||||||
|
#[string] data: String,
|
||||||
|
#[string] file_name: String,
|
||||||
|
) -> bool {
|
||||||
|
op_emit_inner(state, EmitArgs { data, file_name })
|
||||||
}
|
}
|
||||||
|
|
||||||
#[inline]
|
#[inline]
|
||||||
|
@ -590,9 +594,10 @@ pub struct ResolveArgs {
|
||||||
#[serde]
|
#[serde]
|
||||||
fn op_resolve(
|
fn op_resolve(
|
||||||
state: &mut OpState,
|
state: &mut OpState,
|
||||||
#[serde] args: ResolveArgs,
|
#[string] base: String,
|
||||||
|
#[serde] specifiers: Vec<String>,
|
||||||
) -> Result<Vec<(String, String)>, AnyError> {
|
) -> Result<Vec<(String, String)>, AnyError> {
|
||||||
op_resolve_inner(state, args)
|
op_resolve_inner(state, ResolveArgs { base, specifiers })
|
||||||
}
|
}
|
||||||
|
|
||||||
#[inline]
|
#[inline]
|
||||||
|
|
Loading…
Reference in a new issue