mirror of
https://github.com/denoland/deno
synced 2024-08-27 20:09:17 +00:00
fix: allow WPT to successfully exit using --exit-zero
(#23418)
I went with `--exit-zero`. Happy to change to `--no-exit` if feelings are strong. Supercedes #23417
This commit is contained in:
parent
ebc22d9d7e
commit
9acbf90b06
2
.github/workflows/wpt_epoch.yml
vendored
2
.github/workflows/wpt_epoch.yml
vendored
|
@ -72,7 +72,7 @@ jobs:
|
||||||
deno run --unstable --allow-write --allow-read --allow-net \
|
deno run --unstable --allow-write --allow-read --allow-net \
|
||||||
--allow-env --allow-run --lock=tools/deno.lock.json \
|
--allow-env --allow-run --lock=tools/deno.lock.json \
|
||||||
./tests/wpt/wpt.ts run \ \
|
./tests/wpt/wpt.ts run \ \
|
||||||
--binary=$(which deno) --quiet --release --no-ignore --json=wpt.json --wptreport=wptreport.json
|
--binary=$(which deno) --quiet --release --no-ignore --json=wpt.json --wptreport=wptreport.json --exit-zero
|
||||||
|
|
||||||
- name: Upload wpt results to wpt.fyi
|
- name: Upload wpt results to wpt.fyi
|
||||||
env:
|
env:
|
||||||
|
|
|
@ -550,6 +550,12 @@ function reportFinal(
|
||||||
}. ${finalPassedCount} passed; ${finalFailedCount} failed; ${finalExpectedFailedAndFailedCount} expected failure; total ${finalTotalCount} (${duration}ms)\n`,
|
}. ${finalPassedCount} passed; ${finalFailedCount} failed; ${finalExpectedFailedAndFailedCount} expected failure; total ${finalTotalCount} (${duration}ms)\n`,
|
||||||
);
|
);
|
||||||
|
|
||||||
|
// We ignore the exit code of the test run because the CI job reports the
|
||||||
|
// results to WPT.fyi, and we still want to report failure.
|
||||||
|
if (Deno.args.includes("--exit-zero")) {
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
||||||
return failed ? 1 : 0;
|
return failed ? 1 : 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue