development/deno
development/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno synced 2024-08-27 12:00:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: allow reserved word 'mod' in exports (#21537)

Browse source 
This problem occurred trying to load tensorflow.js
```
> import * as tf from 'npm:@tensorflow/tfjs';
Uncaught SyntaxError: Identifier 'mod' has already been declared at file:///Users/ry/Library/Caches/deno/npm/registry.npmjs.org/@tensorflow/tfjs/4.14.0/dist/tf.node.js:167:14
    at async <anonymous>:1:33
```
This commit is contained in:
Ryan Dahl 2023-12-11 11:23:50 -05:00 committed by GitHub
parent 7bf267c197
commit 98121de5be
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
cli/tests/testdata/npm/registry/@denotest/reserved-word-exports/1.0.0/index.cjs vendored
View file

@ -38,6 +38,7 @@ exports["int"] = "int";
exports["interface"] = "interface";
exports["let"] = "let";
exports["long"] = "long";
exports["mod"] = "mod";
exports["native"] = "native";
exports["new"] = "new";
exports["null"] = "null";

2
cli/tests/testdata/npm/reserved_word_exports/main.out vendored
View file

@ -56,6 +56,7 @@ Download http://localhost:4545/npm/registry/@denotest/reserved-word-exports/1.0.
interface: "interface",
let: "let",
long: "long",
mod: "mod",
native: "native",
new: "new",
null: "null",
@ -109,6 +110,7 @@ Download http://localhost:4545/npm/registry/@denotest/reserved-word-exports/1.0.
interface: "interface",
let: "let",
long: "long",
mod: "mod",
native: "native",
new: "new",
null: "null",

1
ext/node/analyze.rs
View file

@ -351,6 +351,7 @@ static RESERVED_WORDS: Lazy<HashSet<&str>> = Lazy::new(|| {
"interface",
"let",
"long",
"mod",
"native",
"new",
"null",