development/deno
development/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno synced 2024-08-27 03:50:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(jupyter): don't require --unstable flag (#21963)

Browse source 
This commit removes the requirement for `--unstable` flag in `deno
jupyter` subcommand. The process will no longer exit if this flag is not
provided, however the subcommand itself is still considered unstable
and might change in the future.

Required for https://github.com/denoland/deno/pull/21452
This commit is contained in:
Bartek Iwańczuk 2024-01-18 23:16:14 +01:00 committed by GitHub
parent 35c1652f56
commit 88bc57d764
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cli/tests/integration/jupyter_tests.rs
View file

@ -1,7 +1,7 @@
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
itest!(jupyter_install_command_not_exists {
args: "jupyter --unstable --install",
args: "jupyter --install",
output: "jupyter/install_command_not_exists.out",
envs: vec![("PATH".to_string(), "".to_string())],
exit_code: 1,

1
cli/tests/testdata/jupyter/install_command_not_exists.out vendored
View file

@ -1,3 +1,4 @@
Warning "deno jupyter" is unstable and might change in the future.
error: Failed to spawn 'jupyter' command. Is JupyterLab installed (https://jupyter.org/install) and available on the PATH?
Caused by:

4
cli/tools/jupyter/install.rs
View file

@ -33,7 +33,7 @@ pub fn status() -> Result<(), AnyError> {
}
}
println!("ℹ️ Deno kernel is not yet installed, run `deno jupyter --unstable --install` to set it up");
println!("ℹ️ Deno kernel is not yet installed, run `deno jupyter --install` to set it up");
Ok(())
}
@ -56,7 +56,7 @@ pub fn install() -> Result<(), AnyError> {
// https://jupyter-client.readthedocs.io/en/stable/kernels.html#kernel-specs
// FIXME(bartlomieju): replace `current_exe` before landing?
let json_data = json!({
"argv": [current_exe().unwrap().to_string_lossy(), "--unstable", "jupyter", "--kernel", "--conn", "{connection_file}"],
"argv": [current_exe().unwrap().to_string_lossy(), "jupyter", "--kernel", "--conn", "{connection_file}"],
"display_name": "Deno",
"language": "typescript",
});

11
cli/tools/jupyter/mod.rs
View file

@ -13,6 +13,7 @@ use deno_core::located_script_name;
use deno_core::resolve_url_or_path;
use deno_core::serde::Deserialize;
use deno_core::serde_json;
use deno_runtime::colors;
use deno_runtime::deno_io::Stdio;
use deno_runtime::deno_io::StdioPipe;
use deno_runtime::permissions::Permissions;
@ -33,12 +34,10 @@ pub async fn kernel(
flags: Flags,
jupyter_flags: JupyterFlags,
) -> Result<(), AnyError> {
if !flags.unstable {
eprintln!(
"Unstable subcommand 'deno jupyter'. The --unstable flag must be provided."
);
std::process::exit(70);
}
log::info!(
"{} \"deno jupyter\" is unstable and might change in the future.",
colors::yellow("Warning"),
);
if !jupyter_flags.install && !jupyter_flags.kernel {
install::status()?;