development/deno
development/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno synced 2024-10-04 07:09:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ext/node): check resource exists before close (#23655)

Browse source
This commit is contained in:
Satya Rohith 2024-05-02 18:34:42 +05:30 committed by GitHub
parent 56ba7f3c23
commit 811280af77
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 12 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
ext/node/polyfills/http2.ts
View file

@ -1015,7 +1015,7 @@ export class ClientHttp2Stream extends Duplex {
this.emit("trailers", trailers);
}
debugHttp2("tryClose");
debugHttp2(">>> tryClose", this[kDenoResponse]?.bodyRid);
core.tryClose(this[kDenoResponse].bodyRid);
this.push(null);
debugHttp2(">>> read null chunk");
@ -1246,10 +1246,12 @@ function finishCloseStream(stream, code) {
debugHttp2(
">>> finishCloseStream close",
stream[kDenoRid],
stream[kDenoResponse].bodyRid,
stream[kDenoResponse]?.bodyRid,
);
core.tryClose(stream[kDenoRid]);
core.tryClose(stream[kDenoResponse].bodyRid);
if (stream[kDenoResponse]) {
core.tryClose(stream[kDenoResponse].bodyRid);
}
stream.emit("close");
});
});
@ -1265,7 +1267,9 @@ function finishCloseStream(stream, code) {
stream[kDenoResponse].bodyRid,
);
core.tryClose(stream[kDenoRid]);
core.tryClose(stream[kDenoResponse].bodyRid);
if (stream[kDenoResponse]) {
core.tryClose(stream[kDenoResponse].bodyRid);
}
nextTick(() => {
stream.emit("close");
});
@ -1273,10 +1277,12 @@ function finishCloseStream(stream, code) {
debugHttp2(
">>> finishCloseStream close2 catch",
stream[kDenoRid],
stream[kDenoResponse].bodyRid,
stream[kDenoResponse]?.bodyRid,
);
core.tryClose(stream[kDenoRid]);
core.tryClose(stream[kDenoResponse].bodyRid);
if (stream[kDenoResponse]) {
core.tryClose(stream[kDenoResponse].bodyRid);
}
nextTick(() => {
stream.emit("close");
});