From 79b95341d9f9804207ff0c17e11085371e0f2e24 Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Wed, 6 Feb 2019 23:43:31 -0500 Subject: [PATCH] Upgrade V8 to 7.4.98 (kKeep fix) (#1640) * Upgrade V8 to 7.4.98 (kKeep fix) https://github.com/denoland/deno/issues/814 https://bugs.chromium.org/p/v8/issues/detail?id=8761 * fix tests --- build | 2 +- gclient_config.py | 3 ++- libdeno/api.cc | 2 +- third_party | 2 +- tools/third_party.py | 3 +-- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/build b/build index 1e3840b6d9..89b12c4642 160000 --- a/build +++ b/build @@ -1 +1 @@ -Subproject commit 1e3840b6d9c3fd3dc7be4fc2c1a2de7798d63df6 +Subproject commit 89b12c46424e9d18499ebecda24cfc5fad0c2c4f diff --git a/gclient_config.py b/gclient_config.py index ca22aca79f..658a4d2fea 100644 --- a/gclient_config.py +++ b/gclient_config.py @@ -1,6 +1,7 @@ # Copyright 2018-2019 the Deno authors. All rights reserved. MIT license. solutions = [{ - 'url': 'https://chromium.googlesource.com/v8/v8.git@7.2.502.16', + 'url': + 'https://chromium.googlesource.com/v8/v8.git@7.4.98', 'name': 'v8', 'deps_file': 'DEPS', 'custom_deps': { diff --git a/libdeno/api.cc b/libdeno/api.cc index 5e451de8e1..e540c95fc0 100644 --- a/libdeno/api.cc +++ b/libdeno/api.cc @@ -84,7 +84,7 @@ deno_buf deno_get_snapshot(Deno* d_) { d->context_.Reset(); auto blob = d->snapshot_creator_->CreateBlob( - v8::SnapshotCreator::FunctionCodeHandling::kClear); + v8::SnapshotCreator::FunctionCodeHandling::kKeep); return {nullptr, 0, reinterpret_cast(const_cast(blob.data)), blob.raw_size}; } diff --git a/third_party b/third_party index 5ff36c849d..c8e3a6e37f 160000 --- a/third_party +++ b/third_party @@ -1 +1 @@ -Subproject commit 5ff36c849d4eece1fe910d74dc5318e554d1822b +Subproject commit c8e3a6e37ff575a6f41168235651f5ef684f1989 diff --git a/tools/third_party.py b/tools/third_party.py index 8bbc319b7f..4f8a8b5b72 100644 --- a/tools/third_party.py +++ b/tools/third_party.py @@ -255,8 +255,7 @@ def download_clang_format(): # Download clang by calling the clang update script. def download_clang(): - run(['python', - tp('v8/tools/clang/scripts/update.py'), '--if-needed'], + run(['python', tp('v8/tools/clang/scripts/update.py')], env=google_env())