development/deno
development/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno synced 2024-09-13 13:21:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

ref(cli): Add better error message when powershell is missing during upgrade (#17759)

Browse source 
Closes https://github.com/denoland/deno/issues/17756
This commit is contained in:
Kamil Ogórek 2023-02-16 20:14:57 +01:00 committed by GitHub
parent 0aeb8bc759
commit 6e1b737400
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
cli/tools/upgrade.rs
View file

@ -511,7 +511,17 @@ pub fn unpack_into_dir(
.arg(format!("'{}'", &archive_path.to_str().unwrap()))
.arg("-DestinationPath")
.arg(format!("'{}'", &temp_dir_path.to_str().unwrap()))
.spawn()?
.spawn()
.map_err(|err| {
if err.kind() == std::io::ErrorKind::NotFound {
std::io::Error::new(
std::io::ErrorKind::NotFound,
"`powershell.exe` was not found in your PATH",
)
} else {
err
}
})?
.wait()?
}
"zip" => {
@ -524,7 +534,7 @@ pub fn unpack_into_dir(
if err.kind() == std::io::ErrorKind::NotFound {
std::io::Error::new(
std::io::ErrorKind::NotFound,
"`unzip` was not found on your PATH, please install `unzip`",
"`unzip` was not found in your PATH, please install `unzip`",
)
} else {
err