From 683a38e47c47609d28bc6964f4b082885e477bf3 Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Fri, 24 Sep 2021 18:35:35 -0400 Subject: [PATCH] refactor: Remove unused code (#12210) --- cli/file_fetcher.rs | 2 +- core/inspector.rs | 6 ------ core/runtime.rs | 16 ---------------- runtime/tokio_util.rs | 9 --------- runtime/web_worker.rs | 2 +- 5 files changed, 2 insertions(+), 33 deletions(-) diff --git a/cli/file_fetcher.rs b/cli/file_fetcher.rs index 3e259ed54a..131685e491 100644 --- a/cli/file_fetcher.rs +++ b/cli/file_fetcher.rs @@ -213,7 +213,7 @@ pub fn map_content_type( } /// Remove shebangs from the start of source code strings -pub fn strip_shebang(mut value: String) -> String { +fn strip_shebang(mut value: String) -> String { if value.starts_with("#!") { if let Some(mid) = value.find('\n') { let (_, rest) = value.split_at(mid); diff --git a/core/inspector.rs b/core/inspector.rs index 74e50dc693..c4dddc5d68 100644 --- a/core/inspector.rs +++ b/core/inspector.rs @@ -50,12 +50,6 @@ pub struct InspectorSessionProxy { pub rx: SessionProxyReceiver, } -impl InspectorSessionProxy { - pub fn split(self) -> (SessionProxySender, SessionProxyReceiver) { - (self.tx, self.rx) - } -} - #[derive(Clone, Copy)] enum PollState { Idle, diff --git a/core/runtime.rs b/core/runtime.rs index 9071463b50..ddbfea0c17 100644 --- a/core/runtime.rs +++ b/core/runtime.rs @@ -1424,22 +1424,6 @@ impl JsRuntime { Ok(root_id) } - /// Asynchronously load specified module and all of its dependencies - /// - /// User must call `JsRuntime::mod_evaluate` with returned `ModuleId` - /// manually after load is finished. - #[deprecated( - since = "0.100.0", - note = "This method had a bug, marking multiple modules loaded as \"main\". Use `load_main_module` or `load_side_module` instead." - )] - pub async fn load_module( - &mut self, - specifier: &ModuleSpecifier, - code: Option, - ) -> Result { - self.load_main_module(specifier, code).await - } - fn poll_pending_ops( &mut self, cx: &mut Context, diff --git a/runtime/tokio_util.rs b/runtime/tokio_util.rs index 5ee45325d4..7a6f4d49e6 100644 --- a/runtime/tokio_util.rs +++ b/runtime/tokio_util.rs @@ -13,12 +13,3 @@ pub fn create_basic_runtime() -> tokio::runtime::Runtime { .build() .unwrap() } - -// TODO(ry) rename to run_local ? -pub fn run_basic(future: F) -> R -where - F: std::future::Future, -{ - let rt = create_basic_runtime(); - rt.block_on(future) -} diff --git a/runtime/web_worker.rs b/runtime/web_worker.rs index 528546e9a1..7dd4082923 100644 --- a/runtime/web_worker.rs +++ b/runtime/web_worker.rs @@ -505,7 +505,7 @@ impl WebWorker { } } - pub fn poll_event_loop( + fn poll_event_loop( &mut self, cx: &mut Context, wait_for_inspector: bool,