development/deno
development/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno synced 2024-08-27 12:00:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ext/node): ServerResponse getHeader() return undefined (#21525)

Browse source 
Matches Node's return type.

Next.js check for `if (header === undefined)`:

e02fe314dc/packages/next/src/server/base-http/node.ts (L93)
This commit is contained in:
Divy Srivastava 2023-12-11 11:11:59 +05:30 committed by GitHub
parent e8fc7c20b7
commit 5e24e28318
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
cli/tests/unit_node/http_test.ts
View file

@ -874,3 +874,24 @@ Deno.test("[node/http] node:http request.setHeader(header, null) doesn't throw",
req.destroy();
}
});
Deno.test("[node/http] ServerResponse getHeader", async () => {
const { promise, resolve } = Promise.withResolvers<void>();
const server = http.createServer((_req, res) => {
res.setHeader("foo", "bar");
assertEquals(res.getHeader("foo"), "bar");
assertEquals(res.getHeader("ligma"), undefined);
res.end("Hello World");
});
server.listen(async () => {
const { port } = server.address() as { port: number };
const res = await fetch(`http://localhost:${port}`);
assertEquals(await res.text(), "Hello World");
server.close(() => {
resolve();
});
});
await promise;
});

2
ext/node/polyfills/http.ts
View file

@ -1394,7 +1394,7 @@ export class ServerResponse extends NodeWritable {
}
getHeader(name: string) {
return this.#headers.get(name);
return this.#headers.get(name) ?? undefined;
}
removeHeader(name: string) {
return this.#headers.delete(name);