From 54a3eb585df170c14bdc0e237a8a2276dd705f38 Mon Sep 17 00:00:00 2001 From: Luca Casonato Date: Tue, 20 Feb 2024 13:30:34 +0100 Subject: [PATCH] fix(publish): print files that will be published (#22495) --- cli/tools/registry/mod.rs | 10 ++++++++++ cli/tools/registry/tar.rs | 2 ++ tests/testdata/publish/dry_run.out | 4 ++++ tests/testdata/publish/symlink.out | 3 +++ 4 files changed, 19 insertions(+) diff --git a/cli/tools/registry/mod.rs b/cli/tools/registry/mod.rs index 586115f27d..37bd3616b4 100644 --- a/cli/tools/registry/mod.rs +++ b/cli/tools/registry/mod.rs @@ -828,6 +828,16 @@ pub async fn publish( } if publish_flags.dry_run { + for (_, package) in prepared_data.package_by_name { + log::info!( + "{} of {} with files:", + colors::green_bold("Simulating publish"), + colors::gray(package.display_name()), + ); + for file in &package.tarball.files { + log::info!(" {} ({})", file.specifier, human_size(file.size as f64),); + } + } log::warn!("{} Aborting due to --dry-run", colors::yellow("Warning")); return Ok(()); } diff --git a/cli/tools/registry/tar.rs b/cli/tools/registry/tar.rs index 2fdb60f633..3dc2616fa0 100644 --- a/cli/tools/registry/tar.rs +++ b/cli/tools/registry/tar.rs @@ -160,6 +160,8 @@ pub fn create_gzipped_tarball( write!(&mut hash, "{:02x}", byte).unwrap(); } + files.sort_by(|a, b| a.specifier.cmp(&b.specifier)); + Ok(PublishableTarball { files, hash, diff --git a/tests/testdata/publish/dry_run.out b/tests/testdata/publish/dry_run.out index 1fa5932945..679aa8f399 100644 --- a/tests/testdata/publish/dry_run.out +++ b/tests/testdata/publish/dry_run.out @@ -1,3 +1,7 @@ Checking for slow types in the public API... Check [WILDCARD] +Simulating publish of @foo/bar@1.0.0 with files: + [WILDCARD]deno.json (140B) + [WILDCARD]mod.ts (114B) + [WILDCARD]std_http.ts (119B) Warning Aborting due to --dry-run diff --git a/tests/testdata/publish/symlink.out b/tests/testdata/publish/symlink.out index 9524494210..e7fc0c2a20 100644 --- a/tests/testdata/publish/symlink.out +++ b/tests/testdata/publish/symlink.out @@ -8,4 +8,7 @@ warning[unsupported-file-type]: unsupported file type 'symlink' info: the file was ignored and will not be published docs: https://jsr.io/go/unsupported-file-type +Simulating publish of @foo/bar@1.0.0 with files: + [WILDCARD]deno.json (87B) + [WILDCARD]mod.ts (56B) Warning Aborting due to --dry-run