diff --git a/cli/BUILD.gn b/cli/BUILD.gn index 484a3f74dc..13a8c0ba09 100644 --- a/cli/BUILD.gn +++ b/cli/BUILD.gn @@ -3,8 +3,8 @@ import("//build/toolchain/cc_wrapper.gni") import("//build_extra/flatbuffers/flatbuffer.gni") import("//build_extra/flatbuffers/rust/rust_flatbuffer.gni") import("//build_extra/rust/rust.gni") +import("//third_party/v8/gni/snapshot_toolchain.gni") import("//third_party/v8/gni/v8.gni") -import("//third_party/v8/snapshot_toolchain.gni") import("../deno.gni") main_extern = [ diff --git a/core/libdeno/binding.cc b/core/libdeno/binding.cc index eac104677c..ee379fc5b1 100644 --- a/core/libdeno/binding.cc +++ b/core/libdeno/binding.cc @@ -101,11 +101,8 @@ void Print(const v8::FunctionCallbackInfo& args) { if (argsLen < 1 || argsLen > 2) { ThrowInvalidArgument(isolate); } - DenoIsolate* d = DenoIsolate::FromIsolate(isolate); - auto context = d->context_.Get(d->isolate_); v8::HandleScope handle_scope(isolate); - bool is_err = - args.Length() >= 2 ? args[1]->BooleanValue(context).ToChecked() : false; + bool is_err = args.Length() >= 2 ? args[1]->BooleanValue(isolate) : false; FILE* file = is_err ? stderr : stdout; #ifdef _WIN32 @@ -322,7 +319,8 @@ void Shared(v8::Local property, v8::ArrayBufferCreationMode::kExternalized); d->shared_ab_.Reset(isolate, ab); } - info.GetReturnValue().Set(d->shared_ab_); + auto shared_ab = d->shared_ab_.Get(isolate); + info.GetReturnValue().Set(shared_ab); } void DenoIsolate::ClearModules() { diff --git a/gclient_config.py b/gclient_config.py index afe5dc39f0..a8ca88c21c 100644 --- a/gclient_config.py +++ b/gclient_config.py @@ -1,7 +1,7 @@ # Copyright 2018-2019 the Deno authors. All rights reserved. MIT license. solutions = [{ 'url': - 'https://chromium.googlesource.com/v8/v8.git@7.6.53', + 'https://chromium.googlesource.com/v8/v8.git@7.7.37', 'name': 'v8', 'deps_file': 'DEPS', 'custom_deps': { diff --git a/third_party b/third_party index 72a4202a03..92159ba506 160000 --- a/third_party +++ b/third_party @@ -1 +1 @@ -Subproject commit 72a4202a0341516115a92aa18951eb3010fb75fa +Subproject commit 92159ba506cf2fb87f4779bebeb07fd3463d0063