From 49be140d2be79b7c94b4375c6a8629b1c0ad99e3 Mon Sep 17 00:00:00 2001 From: Andreu Botella Date: Tue, 22 Mar 2022 22:57:15 +0100 Subject: [PATCH] chore(core): Remove a note that is no longer relevant. (#14069) This note about how `v8::SnapshotCreator::create_blob` must not be called from a `HandleScope` stopped being relevant in #6801, and was now attached to code that had nothing to do with `HandleScope`s. --- core/runtime.rs | 2 -- 1 file changed, 2 deletions(-) diff --git a/core/runtime.rs b/core/runtime.rs index c2c2f4b922..fd884a7095 100644 --- a/core/runtime.rs +++ b/core/runtime.rs @@ -662,8 +662,6 @@ impl JsRuntime { let state = Self::state(self.v8_isolate()); - // Note: create_blob() method must not be called from within a HandleScope. - // TODO(piscisaureus): The rusty_v8 type system should enforce this. state.borrow_mut().global_context.take(); self.inspector.take();