development/deno
development/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno synced 2024-09-13 13:21:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Deno.ppid): improve error message when --unstable is missing (#6717)

Browse source
This commit is contained in:
uki00a 2020-07-13 21:00:56 +09:00 committed by GitHub
parent 1a96a96e10
commit 4731f4800c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 49 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
cli/js/diagnostics_util.ts
View file

@ -64,20 +64,43 @@ const unstableDenoGlobalProperties = [
"Permissions",
"PermissionStatus",
"hostname",
"ppid",
];
function transformMessageText(messageText: string, code: number): string {
if (code === 2339) {
const property = messageText
.replace(/^Property '/, "")
.replace(/' does not exist on type 'typeof Deno'\.$/, "");
if (
messageText.endsWith("on type 'typeof Deno'.") &&
unstableDenoGlobalProperties.includes(property)
) {
return `${messageText} 'Deno.${property}' is an unstable API. Did you forget to run with the '--unstable' flag?`;
switch (code) {
case 2339: {
const property = messageText
.replace(/^Property '/, "")
.replace(/' does not exist on type 'typeof Deno'\./, "");
if (
messageText.endsWith("on type 'typeof Deno'.") &&
unstableDenoGlobalProperties.includes(property)
) {
return `${messageText} 'Deno.${property}' is an unstable API. Did you forget to run with the '--unstable' flag?`;
}
break;
}
case 2551: {
const suggestionMessagePattern = / Did you mean '(.+)'\?$/;
const property = messageText
.replace(/^Property '/, "")
.replace(/' does not exist on type 'typeof Deno'\./, "")
.replace(suggestionMessagePattern, "");
const suggestion = messageText.match(suggestionMessagePattern);
const replacedMessageText = messageText.replace(
suggestionMessagePattern,
""
);
if (suggestion && unstableDenoGlobalProperties.includes(property)) {
const suggestedProperty = suggestion[1];
return `${replacedMessageText} 'Deno.${property}' is an unstable API. Did you forget to run with the '--unstable' flag, or did you mean '${suggestedProperty}'?`;
}
break;
}
}
return messageText;
}

6
cli/tests/integration_tests.rs
View file

@ -2073,6 +2073,12 @@ itest!(unstable_enabled_js {
output: "unstable_enabled_js.out",
});
itest!(unstable_disabled_ts2551 {
args: "run --reload unstable_ts2551.ts",
exit_code: 1,
output: "unstable_disabled_ts2551.out",
});
itest!(_053_import_compression {
args: "run --quiet --reload --allow-net 053_import_compression/main.ts",
output: "053_import_compression.out",

10
cli/tests/unstable_disabled_ts2551.out Normal file
View file

@ -0,0 +1,10 @@
[WILDCARD]
error: TS2551 [ERROR]: Property 'ppid' does not exist on type 'typeof Deno'. 'Deno.ppid' is an unstable API. Did you forget to run with the '--unstable' flag, or did you mean 'pid'?
console.log(Deno.ppid);
~~~~
at [WILDCARD]cli/tests/unstable_ts2551.ts:1:18
'pid' is declared here.
export const pid: number;
~~~
at asset:///lib.deno.ns.d.ts:[WILDCARD]

1
cli/tests/unstable_ts2551.ts Normal file
View file

@ -0,0 +1 @@
console.log(Deno.ppid);