From 46c709e52f712ef7e1e41285ec06e9bbbe10c0a5 Mon Sep 17 00:00:00 2001 From: David Sherret Date: Mon, 15 Apr 2024 18:58:04 -0400 Subject: [PATCH] fix(check): cache bust when changing nodeModulesDir setting (#23355) --- cli/npm/managed/mod.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cli/npm/managed/mod.rs b/cli/npm/managed/mod.rs index 1479643e72..0625911d34 100644 --- a/cli/npm/managed/mod.rs +++ b/cli/npm/managed/mod.rs @@ -604,6 +604,9 @@ impl CliNpmResolver for ManagedCliNpmResolver { .collect::>(); package_reqs.sort_by(|a, b| a.0.cmp(&b.0)); // determinism let mut hasher = FastInsecureHasher::new(); + // ensure the cache gets busted when turning nodeModulesDir on or off + // as this could cause changes in resolution + hasher.write_hashable(self.fs_resolver.node_modules_path().is_some()); for (pkg_req, pkg_nv) in package_reqs { hasher.write_hashable(&pkg_req); hasher.write_hashable(&pkg_nv);