development/deno
development/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno synced 2024-08-27 12:00:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(node/zlib): consistently return buffer (#21747)

Browse source 
This fixes point 3 of https://github.com/denoland/deno/issues/20516

This PR creates consistency between the sync and async versions of the
brotli compress where we will always return a buffer like Node.
This commit is contained in:
Jovi De Croock 2023-12-31 12:53:09 +01:00 committed by GitHub
parent 08fc8d50e3
commit 4339a6c55d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
cli/tests/unit_node/zlib_test.ts
View file

@ -3,6 +3,7 @@
import { assert, assertEquals } from "../../../test_util/std/assert/mod.ts";
import { fromFileUrl, relative } from "../../../test_util/std/path/mod.ts";
import {
brotliCompress,
brotliCompressSync,
brotliDecompressSync,
createBrotliCompress,
@ -19,6 +20,18 @@ Deno.test("brotli compression sync", () => {
assertEquals(decompressed.toString(), "hello world");
});
Deno.test("brotli compression async", async () => {
const buf = Buffer.from("hello world");
const compressed: Buffer = await new Promise((resolve) =>
brotliCompress(buf, (_, res) => {
return resolve(res);
})
);
assertEquals(compressed instanceof Buffer, true);
const decompressed = brotliDecompressSync(compressed);
assertEquals(decompressed.toString(), "hello world");
});
Deno.test("brotli compression", async () => {
const { promise, resolve } = Promise.withResolvers<void>();
const compress = createBrotliCompress();

2
ext/node/polyfills/_brotli.js
View file

@ -126,7 +126,7 @@ export function brotliCompress(
const { quality, lgwin, mode } = oneOffCompressOptions(options);
op_brotli_compress_async(buf, quality, lgwin, mode)
.then((result) => callback(null, result))
.then((result) => callback(null, Buffer.from(result)))
.catch((err) => callback(err));
}