From 39cbaa6d34c249afc4b197836da1fa6dd143cbf9 Mon Sep 17 00:00:00 2001 From: Doni Rubiagatra Date: Fri, 6 Jan 2023 09:09:39 +0700 Subject: [PATCH] fix(cli): uninstall command accept short flags (#17259) --- cli/args/flags.rs | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/cli/args/flags.rs b/cli/args/flags.rs index f3ba85e451..bae6bb0d58 100644 --- a/cli/args/flags.rs +++ b/cli/args/flags.rs @@ -1312,8 +1312,7 @@ fn uninstall_subcommand<'a>() -> Command<'a> { .arg( Arg::new("name") .required(true) - .multiple_occurrences(false) - .allow_hyphen_values(true)) + .multiple_occurrences(false)) .arg( Arg::new("root") .long("root") @@ -5004,6 +5003,27 @@ mod tests { ); } + #[test] + fn uninstall() { + let r = flags_from_vec(svec!["deno", "uninstall", "file_server"]); + assert_eq!( + r.unwrap(), + Flags { + subcommand: DenoSubcommand::Uninstall(UninstallFlags { + name: "file_server".to_string(), + root: None, + }), + ..Flags::default() + } + ); + } + + #[test] + fn uninstall_with_help_flag() { + let r = flags_from_vec(svec!["deno", "uninstall", "--help"]); + assert_eq!(r.err().unwrap().kind(), clap::ErrorKind::DisplayHelp); + } + #[test] fn log_level() { let r =