development/deno
development/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno synced 2024-09-19 16:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(std/node/fs): Remove unnecessary try-catch (#8908)

Browse source
This commit is contained in:
Yuki Tanaka 2020-12-29 23:26:08 +09:00 committed by GitHub
parent 115de4c81a
commit 0e0ffa417b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 52 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

67
std/node/_fs/_fs_mkdtemp_test.ts
View file

@ -1,5 +1,9 @@
// Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.
import { assert } from "../../testing/asserts.ts";
import {
assert,
assertThrows,
assertThrowsAsync,
} from "../../testing/asserts.ts";
import { mkdtemp, mkdtempSync } from "./_fs_mkdtemp.ts";
import { existsSync } from "./_fs_exists.ts";
import { env } from "../process.ts";
@ -16,56 +20,32 @@ const mkdtempP = promisify(mkdtemp);
Deno.test({
name: "[node/fs] mkdtemp",
fn: async () => {
try {
const directory = await mkdtempP(prefix);
assert(existsSync(directory));
Deno.removeSync(directory);
} catch (error) {
assert(false);
}
const directory = await mkdtempP(prefix);
assert(existsSync(directory));
Deno.removeSync(directory);
},
});
Deno.test({
name: "[node/fs] mkdtemp (does not exists)",
fn: async () => {
try {
const directory = await mkdtempP(doesNotExists);
// should have thrown already...
assert(!existsSync(directory));
Deno.removeSync(directory);
} catch (error) {
assert(true);
}
await assertThrowsAsync(() => mkdtempP(doesNotExists));
},
});
Deno.test({
name: "[node/fs] mkdtemp (with options)",
fn: async () => {
try {
const directory = await mkdtempP(prefix, options);
assert(existsSync(directory));
Deno.removeSync(directory);
} catch (error) {
assert(false);
}
const directory = await mkdtempP(prefix, options);
assert(existsSync(directory));
Deno.removeSync(directory);
},
});
Deno.test({
name: "[node/fs] mkdtemp (with bad options)",
fn: async () => {
try {
const directory = await mkdtempP(prefix, badOptions);
// should have thrown already...
assert(!existsSync(directory));
Deno.removeSync(directory);
} catch (error) {
assert(true);
}
await assertThrowsAsync(() => mkdtempP(prefix, badOptions));
},
});
@ -82,16 +62,7 @@ Deno.test({
Deno.test({
name: "[node/fs] mkdtempSync (does not exists)",
fn: () => {
try {
const directory = mkdtempSync(doesNotExists);
// should have thrown already...
const dirExists = existsSync(directory);
Deno.removeSync(directory);
assert(!dirExists);
} catch (error) {
assert(true);
}
assertThrows(() => mkdtempSync(doesNotExists));
},
});
@ -108,14 +79,6 @@ Deno.test({
Deno.test({
name: "[node/fs] mkdtempSync (with bad options)",
fn: () => {
try {
const directory = mkdtempSync(prefix, badOptions);
// should have thrown already...
Deno.removeSync(directory);
assert(false);
} catch (error) {
assert(true);
}
assertThrows(() => mkdtempSync(prefix, badOptions));
},
});