development/deno
development/deno
1
0
Fork 0
mirror of https://github.com/denoland/deno synced 2024-09-13 13:21:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: bug in Deno.copy (#4977)

Browse source
This commit is contained in:
Marcos Casagrande 2020-04-29 03:30:48 +02:00 committed by GitHub
parent 640f6878f6
commit 0703431ec2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
cli/js/io.ts
View file

@ -65,7 +65,11 @@ export async function copy(
if (result === null) {
gotEOF = true;
} else {
n += await dst.write(b.subarray(0, result));
let nwritten = 0;
while (nwritten < result) {
nwritten += await dst.write(b.subarray(nwritten, result));
}
n += nwritten;
}
}
return n;

16
cli/js/tests/io_test.ts
View file

@ -55,3 +55,19 @@ unitTest(async function copyWithCustomBufferSize() {
assertEquals(write.length, xBytes.length);
assertEquals(readSpy.calls, DEFAULT_BUF_SIZE / bufSize + 1);
});
unitTest({ perms: { write: true } }, async function copyBufferToFile() {
const filePath = "test-file.txt";
// bigger than max File possible buffer 16kb
const bufSize = 32 * 1024;
const xBytes = repeat("b", bufSize);
const reader = new Deno.Buffer(xBytes.buffer as ArrayBuffer);
const write = await Deno.open(filePath, { write: true, create: true });
const n = await Deno.copy(reader, write, { bufSize });
assertEquals(n, xBytes.length);
write.close();
await Deno.remove(filePath);
});