mirror of
https://github.com/rust-lang/cargo
synced 2024-10-13 19:22:33 +00:00
b0a2252063
Stricter need_dev_deps behaviour The previous PR (#5012) contained an unnecessary work-around for behaviour of `--all-targets` that was misunderstood. This PR removes that work-around and adds some tests and comments to clarify the behaviour for future contributors, which may help to make easier a future fix for #5177 and #5178.
598 lines
14 KiB
Rust
598 lines
14 KiB
Rust
use cargotest::support::{execs, project};
|
|
use hamcrest::assert_that;
|
|
|
|
const CARGO_RUSTC_ERROR: &'static str =
|
|
"[ERROR] extra arguments to `rustc` can only be passed to one target, consider filtering
|
|
the package by passing e.g. `--lib` or `--bin NAME` to specify a single target";
|
|
|
|
#[test]
|
|
fn build_lib_for_foo() {
|
|
let p = project("foo")
|
|
.file(
|
|
"Cargo.toml",
|
|
r#"
|
|
[package]
|
|
name = "foo"
|
|
version = "0.0.1"
|
|
authors = []
|
|
"#,
|
|
)
|
|
.file(
|
|
"src/main.rs",
|
|
r#"
|
|
fn main() {}
|
|
"#,
|
|
)
|
|
.file("src/lib.rs", r#" "#)
|
|
.build();
|
|
|
|
assert_that(
|
|
p.cargo("rustc").arg("--lib").arg("-v"),
|
|
execs().with_status(0).with_stderr(format!(
|
|
"\
|
|
[COMPILING] foo v0.0.1 ({url})
|
|
[RUNNING] `rustc --crate-name foo src[/]lib.rs --crate-type lib \
|
|
--emit=dep-info,link -C debuginfo=2 \
|
|
-C metadata=[..] \
|
|
--out-dir [..] \
|
|
-L dependency={dir}[/]target[/]debug[/]deps`
|
|
[FINISHED] dev [unoptimized + debuginfo] target(s) in [..]
|
|
",
|
|
dir = p.root().display(),
|
|
url = p.url()
|
|
)),
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn lib() {
|
|
let p = project("foo")
|
|
.file(
|
|
"Cargo.toml",
|
|
r#"
|
|
[package]
|
|
name = "foo"
|
|
version = "0.0.1"
|
|
authors = []
|
|
"#,
|
|
)
|
|
.file(
|
|
"src/main.rs",
|
|
r#"
|
|
fn main() {}
|
|
"#,
|
|
)
|
|
.file("src/lib.rs", r#" "#)
|
|
.build();
|
|
|
|
assert_that(
|
|
p.cargo("rustc")
|
|
.arg("--lib")
|
|
.arg("-v")
|
|
.arg("--")
|
|
.arg("-C")
|
|
.arg("debug-assertions=off"),
|
|
execs().with_status(0).with_stderr(format!(
|
|
"\
|
|
[COMPILING] foo v0.0.1 ({url})
|
|
[RUNNING] `rustc --crate-name foo src[/]lib.rs --crate-type lib \
|
|
--emit=dep-info,link -C debuginfo=2 \
|
|
-C debug-assertions=off \
|
|
-C metadata=[..] \
|
|
--out-dir [..] \
|
|
-L dependency={dir}[/]target[/]debug[/]deps`
|
|
[FINISHED] dev [unoptimized + debuginfo] target(s) in [..]
|
|
",
|
|
dir = p.root().display(),
|
|
url = p.url()
|
|
)),
|
|
)
|
|
}
|
|
|
|
#[test]
|
|
fn build_main_and_allow_unstable_options() {
|
|
let p = project("foo")
|
|
.file(
|
|
"Cargo.toml",
|
|
r#"
|
|
[package]
|
|
name = "foo"
|
|
version = "0.0.1"
|
|
authors = []
|
|
"#,
|
|
)
|
|
.file(
|
|
"src/main.rs",
|
|
r#"
|
|
fn main() {}
|
|
"#,
|
|
)
|
|
.file("src/lib.rs", r#" "#)
|
|
.build();
|
|
|
|
assert_that(
|
|
p.cargo("rustc -v --bin foo -- -C debug-assertions"),
|
|
execs().with_status(0).with_stderr(&format!(
|
|
"\
|
|
[COMPILING] {name} v{version} ({url})
|
|
[RUNNING] `rustc --crate-name {name} src[/]lib.rs --crate-type lib \
|
|
--emit=dep-info,link -C debuginfo=2 \
|
|
-C metadata=[..] \
|
|
--out-dir [..] \
|
|
-L dependency={dir}[/]target[/]debug[/]deps`
|
|
[RUNNING] `rustc --crate-name {name} src[/]main.rs --crate-type bin \
|
|
--emit=dep-info,link -C debuginfo=2 \
|
|
-C debug-assertions \
|
|
-C metadata=[..] \
|
|
--out-dir [..] \
|
|
-L dependency={dir}[/]target[/]debug[/]deps \
|
|
--extern {name}={dir}[/]target[/]debug[/]deps[/]lib{name}-[..].rlib`
|
|
[FINISHED] dev [unoptimized + debuginfo] target(s) in [..]
|
|
",
|
|
dir = p.root().display(),
|
|
url = p.url(),
|
|
name = "foo",
|
|
version = "0.0.1"
|
|
)),
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn fails_when_trying_to_build_main_and_lib_with_args() {
|
|
let p = project("foo")
|
|
.file(
|
|
"Cargo.toml",
|
|
r#"
|
|
[package]
|
|
name = "foo"
|
|
version = "0.0.1"
|
|
authors = []
|
|
"#,
|
|
)
|
|
.file(
|
|
"src/main.rs",
|
|
r#"
|
|
fn main() {}
|
|
"#,
|
|
)
|
|
.file("src/lib.rs", r#" "#)
|
|
.build();
|
|
|
|
assert_that(
|
|
p.cargo("rustc")
|
|
.arg("-v")
|
|
.arg("--")
|
|
.arg("-C")
|
|
.arg("debug-assertions"),
|
|
execs().with_status(101).with_stderr(CARGO_RUSTC_ERROR),
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn build_with_args_to_one_of_multiple_binaries() {
|
|
let p = project("foo")
|
|
.file(
|
|
"Cargo.toml",
|
|
r#"
|
|
[package]
|
|
name = "foo"
|
|
version = "0.0.1"
|
|
authors = []
|
|
"#,
|
|
)
|
|
.file(
|
|
"src/bin/foo.rs",
|
|
r#"
|
|
fn main() {}
|
|
"#,
|
|
)
|
|
.file(
|
|
"src/bin/bar.rs",
|
|
r#"
|
|
fn main() {}
|
|
"#,
|
|
)
|
|
.file(
|
|
"src/bin/baz.rs",
|
|
r#"
|
|
fn main() {}
|
|
"#,
|
|
)
|
|
.file("src/lib.rs", r#" "#)
|
|
.build();
|
|
|
|
assert_that(
|
|
p.cargo("rustc -v --bin bar -- -C debug-assertions"),
|
|
execs().with_status(0).with_stderr(format!(
|
|
"\
|
|
[COMPILING] foo v0.0.1 ({url})
|
|
[RUNNING] `rustc --crate-name foo src[/]lib.rs --crate-type lib --emit=dep-info,link \
|
|
-C debuginfo=2 -C metadata=[..] \
|
|
--out-dir [..]`
|
|
[RUNNING] `rustc --crate-name bar src[/]bin[/]bar.rs --crate-type bin --emit=dep-info,link \
|
|
-C debuginfo=2 -C debug-assertions [..]`
|
|
[FINISHED] dev [unoptimized + debuginfo] target(s) in [..]
|
|
",
|
|
url = p.url()
|
|
)),
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn fails_with_args_to_all_binaries() {
|
|
let p = project("foo")
|
|
.file(
|
|
"Cargo.toml",
|
|
r#"
|
|
[package]
|
|
name = "foo"
|
|
version = "0.0.1"
|
|
authors = []
|
|
"#,
|
|
)
|
|
.file(
|
|
"src/bin/foo.rs",
|
|
r#"
|
|
fn main() {}
|
|
"#,
|
|
)
|
|
.file(
|
|
"src/bin/bar.rs",
|
|
r#"
|
|
fn main() {}
|
|
"#,
|
|
)
|
|
.file(
|
|
"src/bin/baz.rs",
|
|
r#"
|
|
fn main() {}
|
|
"#,
|
|
)
|
|
.file("src/lib.rs", r#" "#)
|
|
.build();
|
|
|
|
assert_that(
|
|
p.cargo("rustc")
|
|
.arg("-v")
|
|
.arg("--")
|
|
.arg("-C")
|
|
.arg("debug-assertions"),
|
|
execs().with_status(101).with_stderr(CARGO_RUSTC_ERROR),
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn build_with_args_to_one_of_multiple_tests() {
|
|
let p = project("foo")
|
|
.file(
|
|
"Cargo.toml",
|
|
r#"
|
|
[package]
|
|
name = "foo"
|
|
version = "0.0.1"
|
|
authors = []
|
|
"#,
|
|
)
|
|
.file("tests/foo.rs", r#" "#)
|
|
.file("tests/bar.rs", r#" "#)
|
|
.file("tests/baz.rs", r#" "#)
|
|
.file("src/lib.rs", r#" "#)
|
|
.build();
|
|
|
|
assert_that(
|
|
p.cargo("rustc -v --test bar -- -C debug-assertions"),
|
|
execs().with_status(0).with_stderr(format!(
|
|
"\
|
|
[COMPILING] foo v0.0.1 ({url})
|
|
[RUNNING] `rustc --crate-name foo src[/]lib.rs --crate-type lib --emit=dep-info,link \
|
|
-C debuginfo=2 -C metadata=[..] \
|
|
--out-dir [..]`
|
|
[RUNNING] `rustc --crate-name bar tests[/]bar.rs --emit=dep-info,link -C debuginfo=2 \
|
|
-C debug-assertions [..]--test[..]`
|
|
[FINISHED] dev [unoptimized + debuginfo] target(s) in [..]
|
|
",
|
|
url = p.url()
|
|
)),
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn build_foo_with_bar_dependency() {
|
|
let foo = project("foo")
|
|
.file(
|
|
"Cargo.toml",
|
|
r#"
|
|
[package]
|
|
name = "foo"
|
|
version = "0.0.1"
|
|
authors = []
|
|
|
|
[dependencies.bar]
|
|
path = "../bar"
|
|
"#,
|
|
)
|
|
.file(
|
|
"src/main.rs",
|
|
r#"
|
|
extern crate bar;
|
|
fn main() {
|
|
bar::baz()
|
|
}
|
|
"#,
|
|
)
|
|
.build();
|
|
let _bar = project("bar")
|
|
.file(
|
|
"Cargo.toml",
|
|
r#"
|
|
[package]
|
|
name = "bar"
|
|
version = "0.1.0"
|
|
authors = []
|
|
"#,
|
|
)
|
|
.file(
|
|
"src/lib.rs",
|
|
r#"
|
|
pub fn baz() {}
|
|
"#,
|
|
)
|
|
.build();
|
|
|
|
assert_that(
|
|
foo.cargo("rustc")
|
|
.arg("-v")
|
|
.arg("--")
|
|
.arg("-C")
|
|
.arg("debug-assertions"),
|
|
execs().with_status(0).with_stderr(format!(
|
|
"\
|
|
[COMPILING] bar v0.1.0 ([..])
|
|
[RUNNING] `[..] -C debuginfo=2 [..]`
|
|
[COMPILING] foo v0.0.1 ({url})
|
|
[RUNNING] `[..] -C debuginfo=2 -C debug-assertions [..]`
|
|
[FINISHED] dev [unoptimized + debuginfo] target(s) in [..]
|
|
",
|
|
url = foo.url()
|
|
)),
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn build_only_bar_dependency() {
|
|
let foo = project("foo")
|
|
.file(
|
|
"Cargo.toml",
|
|
r#"
|
|
[package]
|
|
name = "foo"
|
|
version = "0.0.1"
|
|
authors = []
|
|
|
|
[dependencies.bar]
|
|
path = "../bar"
|
|
"#,
|
|
)
|
|
.file(
|
|
"src/main.rs",
|
|
r#"
|
|
extern crate bar;
|
|
fn main() {
|
|
bar::baz()
|
|
}
|
|
"#,
|
|
)
|
|
.build();
|
|
let _bar = project("bar")
|
|
.file(
|
|
"Cargo.toml",
|
|
r#"
|
|
[package]
|
|
name = "bar"
|
|
version = "0.1.0"
|
|
authors = []
|
|
"#,
|
|
)
|
|
.file(
|
|
"src/lib.rs",
|
|
r#"
|
|
pub fn baz() {}
|
|
"#,
|
|
)
|
|
.build();
|
|
|
|
assert_that(
|
|
foo.cargo("rustc -v -p bar -- -C debug-assertions"),
|
|
execs().with_status(0).with_stderr(
|
|
"\
|
|
[COMPILING] bar v0.1.0 ([..])
|
|
[RUNNING] `rustc --crate-name bar [..] --crate-type lib [..] -C debug-assertions [..]`
|
|
[FINISHED] dev [unoptimized + debuginfo] target(s) in [..]
|
|
",
|
|
),
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn targets_selected_default() {
|
|
let p = project("foo")
|
|
.file(
|
|
"Cargo.toml",
|
|
r#"
|
|
[package]
|
|
name = "foo"
|
|
version = "0.1.0"
|
|
authors = []
|
|
"#,
|
|
)
|
|
.file("src/main.rs", "fn main() {}")
|
|
.build();
|
|
assert_that(
|
|
p.cargo("rustc").arg("-v"),
|
|
execs().with_status(0)
|
|
// bin
|
|
.with_stderr_contains("\
|
|
[RUNNING] `rustc --crate-name foo src[/]main.rs --crate-type bin \
|
|
--emit=dep-info,link[..]")
|
|
// bench
|
|
.with_stderr_does_not_contain("\
|
|
[RUNNING] `rustc --crate-name foo src[/]main.rs --emit=dep-info,link \
|
|
-C opt-level=3 --test [..]")
|
|
// unit test
|
|
.with_stderr_does_not_contain("\
|
|
[RUNNING] `rustc --crate-name foo src[/]main.rs --emit=dep-info,link \
|
|
-C debuginfo=2 --test [..]"),
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn targets_selected_all() {
|
|
let p = project("foo")
|
|
.file(
|
|
"Cargo.toml",
|
|
r#"
|
|
[package]
|
|
name = "foo"
|
|
version = "0.1.0"
|
|
authors = []
|
|
"#,
|
|
)
|
|
.file("src/main.rs", "fn main() {}")
|
|
.build();
|
|
assert_that(
|
|
p.cargo("rustc").arg("-v").arg("--all-targets"),
|
|
execs().with_status(0)
|
|
// bin
|
|
.with_stderr_contains("\
|
|
[RUNNING] `rustc --crate-name foo src[/]main.rs --crate-type bin \
|
|
--emit=dep-info,link[..]")
|
|
// bench
|
|
.with_stderr_contains("\
|
|
[RUNNING] `rustc --crate-name foo src[/]main.rs --emit=dep-info,link \
|
|
-C opt-level=3 --test [..]")
|
|
// unit test
|
|
.with_stderr_contains("\
|
|
[RUNNING] `rustc --crate-name foo src[/]main.rs --emit=dep-info,link \
|
|
-C debuginfo=2 --test [..]"),
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn fail_with_multiple_packages() {
|
|
let foo = project("foo")
|
|
.file(
|
|
"Cargo.toml",
|
|
r#"
|
|
[package]
|
|
name = "foo"
|
|
version = "0.0.1"
|
|
authors = []
|
|
|
|
[dependencies.bar]
|
|
path = "../bar"
|
|
|
|
[dependencies.baz]
|
|
path = "../baz"
|
|
"#,
|
|
)
|
|
.file(
|
|
"src/main.rs",
|
|
r#"
|
|
fn main() {}
|
|
"#,
|
|
)
|
|
.build();
|
|
|
|
let _bar = project("bar")
|
|
.file(
|
|
"Cargo.toml",
|
|
r#"
|
|
[package]
|
|
name = "bar"
|
|
version = "0.1.0"
|
|
authors = []
|
|
"#,
|
|
)
|
|
.file(
|
|
"src/main.rs",
|
|
r#"
|
|
fn main() {
|
|
if cfg!(flag = "1") { println!("Yeah from bar!"); }
|
|
}
|
|
"#,
|
|
)
|
|
.build();
|
|
|
|
let _baz = project("baz")
|
|
.file(
|
|
"Cargo.toml",
|
|
r#"
|
|
[package]
|
|
name = "baz"
|
|
version = "0.1.0"
|
|
authors = []
|
|
"#,
|
|
)
|
|
.file(
|
|
"src/main.rs",
|
|
r#"
|
|
fn main() {
|
|
if cfg!(flag = "1") { println!("Yeah from baz!"); }
|
|
}
|
|
"#,
|
|
)
|
|
.build();
|
|
|
|
assert_that(
|
|
foo.cargo("rustc -v -p bar -p baz"),
|
|
execs().with_status(1).with_stderr_contains(
|
|
"\
|
|
error: The argument '--package <SPEC>' was provided more than once, \
|
|
but cannot be used multiple times
|
|
",
|
|
),
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn rustc_with_other_profile() {
|
|
let p = project("foo")
|
|
.file(
|
|
"Cargo.toml",
|
|
r#"
|
|
[package]
|
|
name = "foo"
|
|
version = "0.0.1"
|
|
authors = []
|
|
|
|
[dev-dependencies]
|
|
a = { path = "a" }
|
|
"#,
|
|
)
|
|
.file(
|
|
"src/main.rs",
|
|
r#"
|
|
#[cfg(test)] extern crate a;
|
|
|
|
#[test]
|
|
fn foo() {}
|
|
"#,
|
|
)
|
|
.file(
|
|
"a/Cargo.toml",
|
|
r#"
|
|
[package]
|
|
name = "a"
|
|
version = "0.1.0"
|
|
authors = []
|
|
"#,
|
|
)
|
|
.file("a/src/lib.rs", "")
|
|
.build();
|
|
|
|
assert_that(
|
|
p.cargo("rustc").arg("--profile").arg("test"),
|
|
execs().with_status(0),
|
|
);
|
|
}
|