mirror of
https://github.com/rust-lang/cargo
synced 2024-10-02 05:53:53 +00:00
a04e2e5bd9
cargotest: Fix `with_*_does_not_contain` to support `[..]` and macro matching. I changed it so that it is essentially the opposite of `with_*_contains` to keep it symmetric. Any in-flight PRs using the old style will need to be updated (else they will incorrectly silently pass). Alternatively, we could rename the method to avoid that. The following tests contained brackets, so they were not checking what they thought they were checking. I did a cursory look at them, but perhaps someone else could double-check that they make sense. Asserting what *doesn't* happen can be tricky since there is an infinite number of things that won't happen. Preferably a test would assert that it appears in one scenario and not another (like `incremental_profile` does), but some of them don't or can't. ``` build::incremental_profile build::incremental_config build::cargo_compile_with_workspace_excluded build::build_all_exclude build::targets_selected_default check::targets_selected_default check::check_filters rustc::targets_selected_default rustc_info_cache::rustc_info_cache warn_on_failure::no_warning_on_bin_failure warn_on_failure::warning_on_lib_failure ``` BTW, would you be interested in a PR that adds some documentation to `cargotest`? I've discovered things I didn't know where there. I think some docstrings on some of the methods, and a short guide for new contributors would be helpful. |
||
|---|---|---|
| .. | ||
| testsuite | ||