development/cargo
development/cargo
1
0
Fork 0
mirror of https://github.com/rust-lang/cargo synced 2024-10-14 03:32:39 +00:00
Code Issues Packages Projects Releases Wiki Activity
cargo/tests/testsuite
History
bors 7197c66b36 Auto merge of #8819 - EmbarkStudios:target-root-path, r=ehuss 
Make host_root return host.root(), not host.dest()

Also create host_dest function to let other callsites retain their old functionality. Fixes #8817, verified it works on the original problem reported in the `rust-gpu` repo.

I did two things here:

1) Rename `host_root` (which returns `self.host.dest()`) to be `host_dest`. This has three callsites. I did this to make it more clear that it returns dest, not root.
2) For the callsite that's relevant in #8817, I created a "new" `host_root` function (that returns `self.host.root()`). This means that the callsite that this PR is actually fixing doesn't show up in this diff :/ - but I thought it was more clear this way.

(Also copied the example path docs over from `layout.rs` to hopefully avoid this mistake again in the future)

I tried to look into if the other two callsites should actually be calling `host.root()` instead of `dest`, because I imagine the same mistake could have been made again, but it quickly grew out of my understanding (this is my first time in the cargo codebase). Feel free to let me know if they should also call `host.root()` too, and I can update them.

Thanks! (oh gosh I have no idea what I'm doing, I hope this is right)

r? `@alexcrichton`
2020-10-29 02:30:19 +00:00
..
mock-std Fix mock-std as well 2020-07-29 12:41:49 +09:00
advanced_env.rs Fixes for some test errors on Windows. 2019-12-19 09:44:02 -08:00
alt_registry.rs Fix tests 2020-10-01 09:40:32 +00:00
bad_config.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
bad_manifest_path.rs Minor testsuite organization. 2019-11-24 18:42:45 -08:00
bench.rs test: normalize raw string indentation. 2020-10-10 07:44:57 +08:00
build.rs Merge branch 'master' into feat/glob-pattern 2020-10-18 08:48:30 +08:00
build_plan.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
build_script.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
build_script_env.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
cache_messages.rs Fix cache_messages::rustdoc test broken on beta. 2020-08-26 11:17:57 -07:00
cargo_alias_config.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
cargo_command.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
cargo_features.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
cargo_targets.rs Warn on Windows about reserved target names. 2020-03-02 16:04:25 -08:00
cfg.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
check.rs test: normalize raw string indentation. 2020-10-10 07:44:57 +08:00
clean.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
collisions.rs Don't hash executable filenames on apple platforms. 2020-06-04 16:14:17 -07:00
concurrent.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
config.rs Update toml dependency 2020-10-12 11:22:45 -07:00
config_cli.rs Revert misfeatures 2020-07-07 23:38:26 -06:00
config_include.rs Fix tests with enoent error message on non-english systems. 2020-05-29 12:34:17 -07:00
corrupt_git.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
cross_compile.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
cross_publish.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
custom_target.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
death.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
dep_info.rs Fix test path on windows 2020-10-28 20:45:50 +01:00
directory.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
doc.rs test: normalize raw string indentation. 2020-10-10 07:44:57 +08:00
edition.rs Minor testsuite organization. 2019-11-24 18:42:45 -08:00
error.rs Rework internal errors. 2020-02-17 19:03:57 -08:00
features.rs Add a future-compatibility warning on allowed feature name characters. 2020-10-27 14:23:35 -07:00
features2.rs New namespaced features implementation. 2020-10-23 16:04:41 -07:00
features_namespaced.rs Rename crate: to dep: 2020-10-25 12:51:27 -07:00
fetch.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
fix.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
freshness.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
generate_lockfile.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
git.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
git_auth.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
git_gc.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
glob_targets.rs test: glob support for target selection 2020-10-05 01:24:39 +08:00
help.rs New namespaced features implementation. 2020-10-23 16:04:41 -07:00
init.rs Rephrase message of restricted crate name 2020-09-11 00:39:51 +08:00
install.rs rustfmt 2020-10-28 02:57:22 +08:00
install_upgrade.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
jobserver.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
list_availables.rs test: list availables for clean,tree,update 2020-10-28 02:46:20 +08:00
local_registry.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
locate_project.rs --workspace flag for locate-project to find the workspace root 2020-09-23 18:39:21 -04:00
lockfile_compat.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
login.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
lto.rs Add LTO to the metadata filename hash. 2020-10-05 11:29:01 -07:00
main.rs Auto merge of #8808 - weihanglo:fix/8591, r=ehuss 2020-10-28 16:41:55 +00:00
member_discovery.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
member_errors.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
message_format.rs Add "build-finished" JSON message. 2020-04-04 18:56:50 -07:00
metabuild.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
metadata.rs Test that homepage/documentation values are properly propagated 2020-10-01 09:40:32 +00:00
minimal_versions.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
multitarget.rs clippy fixes 2020-05-01 01:16:30 +02:00
net_config.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
new.rs Update git2. 2020-10-13 18:13:25 -07:00
offline.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
out_dir.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
owner.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
package.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
package_features.rs New namespaced features implementation. 2020-10-23 16:04:41 -07:00
patch.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
path.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
paths.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
pkgid.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
plugins.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
proc_macro.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
profile_config.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
profile_custom.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
profile_overrides.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
profile_targets.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
profiles.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
progress.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
pub_priv.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
publish.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
publish_lockfile.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
read_manifest.rs Fix tests 2020-10-01 09:40:32 +00:00
registry.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
rename_deps.rs New namespaced features implementation. 2020-10-23 16:04:41 -07:00
replace.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
required_features.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
run.rs test: be consistent on error message styles 2020-10-10 06:58:06 +08:00
rustc.rs test: normalize raw string indentation. 2020-10-10 07:44:57 +08:00
rustc_info_cache.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
rustdoc.rs test: normalize raw string indentation. 2020-10-10 07:44:57 +08:00
rustdoc_extern_html.rs Fix rust-docs in CI. 2020-05-26 15:43:28 -07:00
rustdocflags.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
rustflags.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
search.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
shell_quoting.rs Minor testsuite organization. 2019-11-24 18:42:45 -08:00
standard_lib.rs Add a -Zbuild-std-features flag 2020-07-17 07:02:19 -07:00
test.rs fix: emit errors instead of warnings when glob patterns not found 2020-10-10 09:50:36 +08:00
timings.rs Minor testsuite organization. 2019-11-24 18:42:45 -08:00
tool_paths.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
tree.rs Merge branch 'master' into feat/glob-pattern 2020-10-18 08:48:30 +08:00
tree_graph_features.rs Switch --invert to take the package name as an argument. 2020-04-03 19:52:21 -07:00
unit_graph.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
update.rs Fix tests 2020-10-01 09:40:32 +00:00
vendor.rs Mask out system core.autocrlf settings before resetting git repos 2020-07-21 12:38:03 -04:00
verify_project.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
version.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
warn_on_failure.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00
workspaces.rs Rework tests to avoid using -vv 2020-10-15 00:44:04 +02:00
yank.rs Normalize raw string indentation. 2020-09-26 17:59:58 -07:00