Ed Page
8080b870bd
chore: Communicate motivation for AtomucU64
...
Co-authored-by: Weihang Lo <weihanglo@users.noreply.github.com>
2023-11-16 12:34:02 -06:00
Ed Page
93cd5ef846
chore(ci): Catch naive use of AtomicU64 early
...
AtomicU64 is not portable and use of it, without `target_has_atomic`,
will fail CI for rust-lang/rust when the cargo submodule gets updated
(see #12981 ).
If there is a reason to use it, we could always `allow` in that one
case.
2023-11-16 11:58:58 -06:00
Weihang Lo
4cc9208b25
lint: follow convention no capitcal letter in first word
2023-09-14 13:43:47 +08:00
Ed Page
9df5e79dfb
chore: Migrate print-ban from test to clippy
...
This should be more resilient to false positives like in #12245 where a
string contains `println`.
2023-06-09 08:11:49 -05:00
Weihang Lo
9e3bb8588b
clippy: warn disallowed_methods for std::env::var and friends
...
In 11588 we want to avoid reading from environment variables,
11727 did that well. I wonder if we could leverage tools to help
with this. Thankfully, clippy has a `disallowed_methods`[1] lint,
helping us enforce the rule.
[1]: https://rust-lang.github.io/rust-clippy/stable/index.html#disallowed_methods
2023-03-17 12:51:23 +00:00
