Commit graph

6240 commits

Author SHA1 Message Date
eth3lbert 51b794636d
test: migrate weak_dep_features to snapbox 2024-06-22 06:26:56 +08:00
eth3lbert 91569f84b0
test: Add auto-redaction for not found error 2024-06-22 05:13:58 +08:00
bors e35cd55b1a Auto merge of #14068 - weihanglo:snapbox-build, r=epage
test: migrate build to snapbox
2024-06-21 17:29:05 +00:00
bors ce90393a11 Auto merge of #14119 - eth3lbert:snapbox-uuv, r=epage
test: migrate unit_graph, update and vendor to snapbox

### What does this PR try to resolve?

Part of https://github.com/rust-lang/cargo/issues/14039.

Migrate following to snapbox:

- `tests/testsuite/unit_graph.rs`
- `tests/testsuite/update.rs`
- `tests/testsuite/vendor.rs`
2024-06-21 15:45:27 +00:00
Ed Page fd8a91d185 fix(test): Un-redact Packaged files
This is a partial revert of ##14121
(e11d1722bb)

Our focus for redacting (auto or with globs) includes
- run-specific information (timing, hashes, platform-specific wording)
- rustc-specific information

(We tend to use globs for rustc-specific information because there might
be some very specific times we need to care about some of the details)

However, "Packaged files" does not fit into any of that and, for now, we
are erring on the side of redacting less, rather than more, with the
move to snapbox.
As we see how it works out and what the underlying requirements are, we
can revisit this.
2024-06-21 11:05:41 -04:00
bors 922960916d Auto merge of #14121 - dieterplex:redact-file-num, r=weihanglo
test: Auto-redact file number

This is from <https://github.com/rust-lang/cargo/pull/14096#discussion_r1648889843>.

Although the number of files in `cargo package` is important,
we have `validate_crate_contents` and `validate_upload_with_contents`
that verify the exact contents.
Redacting `Packaged` status should be fine.
2024-06-21 13:14:27 +00:00
eth3lbert f978616862
test: migrate vendor to snapbox 2024-06-21 15:19:23 +08:00
eth3lbert c7c1462b28
test: migrate update to snapbox 2024-06-21 15:19:23 +08:00
eth3lbert b424c57e86
test: migrate unit_graph to snapbox 2024-06-21 14:19:21 +08:00
bors cabd5eb276 Auto merge of #14104 - eth3lbert:snapbox-lints, r=weihanglo
test: migrate lints_table and lints/(mod|unknown_lints) to snapbox

### What does this PR try to resolve?

Part of #14039.

Migrate followings to snapbox:
- `tests/testsuite/lints/mod.rs`
- `tests/testsuite/lints/unknown_lints.rs`
- `tests/testsuite/lints_table.rs`
2024-06-21 00:41:07 +00:00
Heng-Yi Wu 2c517d9858
test: migrate testsuite version to snapbox 2024-06-20 19:59:54 +08:00
Heng-Yi Wu 1e0dca3935
test: migrate testsuite verify_project to snapbox 2024-06-20 19:59:54 +08:00
Heng-Yi Wu d6024347fa
test: migrate testsuite precise_pre_release to snapbox 2024-06-20 19:59:54 +08:00
Heng-Yi Wu efbcbb0af7
test: migrate testsuite message_format to snapbox
This reverts commit 2fbba5300c94237960540e176cdc9b0c829d0022.
2024-06-20 19:59:53 +08:00
Heng-Yi Wu a67f4edff4
test: remove deprecated attribute from testsuite death 2024-06-20 19:59:53 +08:00
bors 93ba1e6751 Auto merge of #14110 - epage:edition, r=weihanglo
fix(toml): Warn when edition is unuset, even when MSRV is unset

### What does this PR try to resolve?

This came up in #14108.  This got overlooked when we added the MSRV
limits to the warning.

Users can silence this by setting a very old MSRV.
I didn't bother finding a way to word a specialized message for this.
Wording for this case seemed hard and I figure someone in this situation
knows how to resolve it.
Instead, we are targeting the majority of users who aren't setting a
`package.rust-version` in the first place.

### How should we test and review this PR?

### Additional information
2024-06-19 21:05:07 +00:00
Ed Page bdcf397f06 fix(toml): Warn when edition is unuset, even when MSRV is unset
This came up in #14108.  This got overlooked when we added the MSRV
limits to the warning.

Users can silience this by setting a very old MSRV.
I didn't bother finding a way to word a specialized message for this.
Wording for this case seemed hard and I figure someone in this situation
knows how to resolve it.
Instead, we are targeting the majority of users who aren't setting a
`package.rust-version` in the first place.
2024-06-19 15:00:47 -05:00
Ed Page 4687c86515 test(edition): Without rust-version, no warning shown 2024-06-19 15:00:47 -05:00
Ed Page 601ab1aaea test: Add missing edition fields 2024-06-19 15:00:47 -05:00
bors 6e236509b2 Auto merge of #14093 - heisen-li:alias_command_config, r=weihanglo
test: migrate `cargo_alias_config&cargo_config/mod` to snapbox

### What does this PR try to resolve?

Resolve the following file migration:
`tests/testsuite/cargo_alias_config.rs`
`tests/testsuite/cargo_config/mod.rs`

part of #14039
2024-06-19 19:13:39 +00:00
d1t2 e11d1722bb
test: Auto-redact file number 2024-06-19 20:00:56 +08:00
bors 103e6758f1 Auto merge of #14103 - linyihai:migrate-pub-priv, r=weihanglo
test: Migrate `pub_priv.rs` to snapshot

### What does this PR try to resolve?
Apply snapshot assertion on `tests/testsuite/pub_priv.rs`

### How should we test and review this PR?

The migration is almost one-to-one.

### Additional information

Part of https://github.com/rust-lang/cargo/issues/14039
2024-06-19 11:49:22 +00:00
bors be78abd4fc Auto merge of #14098 - eth3lbert:snapbox-rustdoc, r=weihanglo
test: migrate rustdoc and rustdocflags to snapbox

### What does this PR try to resolve?

Part of #14039.

Migrate following to snapbox:
- `tests/testsuite/rustdoc.rs`
- `tests/testsuite/rustdocflags.rs`
2024-06-19 11:10:56 +00:00
eth3lbert 6c4d59c296
test: migrate lints_table to snapbox 2024-06-19 17:17:02 +08:00
Lin Yihai 485c88c8aa test: Migrate pub_priv.rs to snapshot 2024-06-19 16:23:36 +08:00
eth3lbert fa4f390869
test: migrate rustdocflags to snapbox 2024-06-19 15:28:55 +08:00
eth3lbert 3a46ef16f7
test: migrate rustdoc to snapbox 2024-06-19 15:18:24 +08:00
eth3lbert f75b4d708d
test: migrate lints/unknown_lints to snapbox 2024-06-19 14:21:16 +08:00
eth3lbert 676e97affd
test: migrate lints/mod to snapbox 2024-06-19 14:18:32 +08:00
heisen-li b048d3dc2c test: migrate cargo_config/mod to snapbox 2024-06-19 09:29:28 +08:00
bors 86a3f61c5b Auto merge of #14094 - eth3lbert:snapbox-tree, r=weihanglo
test: migrate tree and tree_graph_features to snapbox

### What does this PR try to resolve?

Part of #14039.

Migrate following to snapbox:
- `tests/testsuite/tree.rs`
- `tests/testsuite/tree_graph_features.rs`
2024-06-18 18:43:53 +00:00
bors b2739badd1 Auto merge of #14069 - heisen-li:build_script_extra, r=weihanglo
test: Migrate some files to snapbox

### What does this PR try to resolve?

This PR addresses the migration of the following files:

`tests/testsuite/build_script_extra_link_arg.rs `
` tests/testsuite/cache_lock.rs `
` tests/testsuite/cache_messages.rs `

part of #14039
2024-06-18 16:57:30 +00:00
eth3lbert 3308d308a2
test: migrate tree_graph_features to snapbox 2024-06-18 23:03:00 +08:00
eth3lbert 3bc397b197
test: migrate tree to snapbox 2024-06-18 23:03:00 +08:00
heisen-li 2e1f7b47c7 test: migrate cache_lock to snapbox 2024-06-18 18:59:47 +08:00
heisen-li 413844bc13 test: migrate cache_message to snapbox 2024-06-18 18:59:06 +08:00
heisen-li 9de3687805 test: migrate cargo_alias_config to snapbox 2024-06-18 12:09:23 +08:00
bors 83a3964417 Auto merge of #14018 - epage:dep_name, r=ehuss
fix(fix): Address problems with implicit -> explicit feature migration

### What does this PR try to resolve?

Within the scope of `cargo fix` there  are two problems
- We wipe out existing feature activations if it has the same name as an optional dependency
- The `Cargo.toml` isn't parseable because the unused optional dependency won't "exist" if just `dep_name/feature_name` is used

Fixes #14010

### How should we test and review this PR?

As for the unused optional dependency not "existing" error,
- #14015 is for improving the message for weak dep features
- #14016 is for re-evaluating how we handle this for strong dep features

Depending on what solution we go with for #14016, we might want to revisit the second migration within this PR.  This is one reason I made the commit separate (in addition to just making it clearer whats happening as this gets into some finer details of features).

### Additional information
2024-06-17 18:09:51 +00:00
bors f911dfdb05 Auto merge of #14088 - weihanglo:cleanup-1.79, r=ehuss
refactor: 1.79 cleanup
2024-06-17 16:14:35 +00:00
Weihang Lo 1185249ff0
test: --check-cfg is stabilized in rustc 1.79.0 2024-06-17 10:09:45 -04:00
rami3l ddd5d2fad1
test: migrate git_shallow to snapbox 2024-06-17 20:00:31 +08:00
rami3l fa31d100a2
test: migrate git_gc to snapbox 2024-06-17 19:59:18 +08:00
heisen-li e41c718229 test: migrate build_script_extra_link_arg to snapbox 2024-06-17 19:31:44 +08:00
bors 8c52c9c33a Auto merge of #14082 - henry40408:issue-14039-timings, r=weihanglo
test: migrate timings_works to snapbox

### What does this PR try to resolve?

Part of https://github.com/rust-lang/cargo/issues/14039.

Migrate `tests/testsuite/timings.rs` to snapbox.

### How should we test and review this PR?

N/A

### Additional information

N/A
2024-06-16 22:36:21 +00:00
Heng-Yi Wu b592aa92da
test: remove diagnostic attribute from member_discovery.rs 2024-06-16 22:02:58 +08:00
Heng-Yi Wu 2eaf66bf10
test: migrate timings_works to snapbox 2024-06-16 21:52:30 +08:00
Heng-Yi Wu 4868bf82ab
test: migrate minimal_versions to snapbox 2024-06-16 11:19:16 +08:00
Lawrence Chou 6ae78e8d86
Fix regression since #14076 is now resolved 2024-06-16 09:13:50 +08:00
Lawrence Chou b254699e29
Revert "Reproduce #14076"
This reverts commit 18f4c3f3d1f90d88c3ea667f51b093d4e1b8deec.
2024-06-16 09:13:36 +08:00
Lawrence Chou fde1321381
Remove Execs::run_expect_error to avoid #14076 2024-06-16 09:13:24 +08:00