development/cargo
development/cargo
1
0
Fork 0
mirror of https://github.com/rust-lang/cargo synced 2024-09-19 07:41:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

added assertions to make sure the path code is correct in graphs

Browse source
This commit is contained in:
Jacob Finkelman 2023-09-19 20:22:13 +00:00
parent 245e69ce10
commit 2284b7a885
1 changed files with 27 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
src/cargo/util/graph.rs
View file

@ -106,6 +106,18 @@ impl<N: Eq + Ord + Clone, E: Default + Clone> Graph<N, E> {
result.push(p);
pkg = p.0;
}
#[cfg(debug_assertions)]
{
for x in result.windows(2) {
let [(n1, _), (n2, Some(e12))] = x else {
unreachable!()
};
assert!(std::ptr::eq(self.edge(n1, n2).unwrap(), *e12));
}
let last = result.last().unwrap().0;
// fixme: this may be wrong when there are cycles, but we dont have them in tests.
assert!(!self.nodes.contains_key(last));
}
result
}
@ -134,6 +146,21 @@ impl<N: Eq + Ord + Clone, E: Default + Clone> Graph<N, E> {
result.push(p);
pkg = p.0;
}
#[cfg(debug_assertions)]
{
for x in result.windows(2) {
let [(n2, _), (n1, Some(e12))] = x else {
unreachable!()
};
assert!(std::ptr::eq(self.edge(n1, n2).unwrap(), *e12));
}
let last = result.last().unwrap().0;
// fixme: this may be wrong when there are cycles, but we dont have them in tests.
assert!(!self
.nodes
.iter()
.any(|(_, adjacent)| adjacent.contains_key(last)));
}
result
}
}