development/cargo
development/cargo
1
0
Fork 0
mirror of https://github.com/rust-lang/cargo synced 2024-10-13 11:12:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Auto merge of #13143 - ChrisDenton:test-changes, r=weihanglo

Browse source 
Don't rely on mtime to test changes

### What does this PR try to resolve?

Fixes #13139 by making sure tests aren't relying on changing the mtime alone

### How should we test and review this PR?

The pattern to watch out for is when a file is created with empty contents, e.g. `.file("foo", "")`, then later the same file updated with empty contents, e.g. `.change_file("foo", "")`. Tests should be making an actual change to the contents.
This commit is contained in:
bors 2023-12-08 21:37:50 +00:00
parent a1449eeb3e 4ef503fc2d
commit 047dc187da
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tests/testsuite/build_script.rs
View file

@ -3471,7 +3471,7 @@ fn rebuild_only_on_explicit_paths() {
// random other files do not affect freshness
println!("run baz");
p.change_file("baz", "");
p.change_file("baz", "// modified");
p.cargo("build -v")
.with_stderr(
"\
@ -3483,7 +3483,7 @@ fn rebuild_only_on_explicit_paths() {
// but changing dependent files does
println!("run foo change");
p.change_file("foo", "");
p.change_file("foo", "// modified");
p.cargo("build -v")
.with_stderr(
"\

2
tests/testsuite/build_script_env.rs
View file

@ -96,7 +96,7 @@ fn rerun_if_env_or_file_changes() {
.with_stderr("[FINISHED] [..]")
.run();
sleep_ms(1000);
p.change_file("foo", "");
p.change_file("foo", "// modified");
p.cargo("check")
.env("FOO", "bar")
.with_stderr(

2
tests/testsuite/freshness.rs
View file

@ -1522,7 +1522,7 @@ fn bust_patched_dep() {
sleep_ms(1000);
}
p.change_file("reg1new/src/lib.rs", "");
p.change_file("reg1new/src/lib.rs", "// modified");
if is_coarse_mtime() {
sleep_ms(1000);
}