2021-07-09 22:30:15 +00:00
|
|
|
//! General tests specifically about diagnostics and other messages.
|
|
|
|
//!
|
|
|
|
//! Tests for message caching can be found in `cache_messages`.
|
|
|
|
|
|
|
|
use cargo_test_support::{process, project, Project};
|
2021-07-16 00:37:21 +00:00
|
|
|
use cargo_util::ProcessError;
|
2021-07-09 22:30:15 +00:00
|
|
|
|
|
|
|
/// Captures the actual diagnostics displayed by rustc. This is done to avoid
|
|
|
|
/// relying on the exact message formatting in rustc.
|
|
|
|
pub fn raw_rustc_output(project: &Project, path: &str, extra: &[&str]) -> String {
|
|
|
|
let mut proc = process("rustc");
|
|
|
|
if cfg!(windows) {
|
|
|
|
// Sanitize in case the caller wants to do direct string comparison with Cargo's output.
|
|
|
|
proc.arg(path.replace('/', "\\"));
|
|
|
|
} else {
|
|
|
|
proc.arg(path);
|
|
|
|
}
|
2021-07-16 00:37:21 +00:00
|
|
|
let rustc_output = match proc
|
2021-07-09 22:30:15 +00:00
|
|
|
.arg("--crate-type=lib")
|
|
|
|
.args(extra)
|
|
|
|
.cwd(project.root())
|
|
|
|
.exec_with_output()
|
2021-07-16 00:37:21 +00:00
|
|
|
{
|
|
|
|
Ok(output) => output.stderr,
|
|
|
|
Err(e) => e.downcast::<ProcessError>().unwrap().stderr.unwrap(),
|
|
|
|
};
|
2021-07-09 22:30:15 +00:00
|
|
|
// Do a little dance to remove rustc's "warnings emitted" message and the subsequent newline.
|
2021-07-16 00:37:21 +00:00
|
|
|
let stderr = std::str::from_utf8(&rustc_output).expect("utf8");
|
2021-07-09 22:30:15 +00:00
|
|
|
let mut lines = stderr.lines();
|
|
|
|
let mut result = String::new();
|
|
|
|
while let Some(line) = lines.next() {
|
2021-07-16 00:37:21 +00:00
|
|
|
if line.contains("warning emitted")
|
|
|
|
|| line.contains("warnings emitted")
|
|
|
|
|| line.contains("aborting due to")
|
|
|
|
{
|
2021-07-09 22:30:15 +00:00
|
|
|
// Eat blank line.
|
|
|
|
match lines.next() {
|
|
|
|
None | Some("") => continue,
|
|
|
|
Some(s) => panic!("unexpected str {}", s),
|
|
|
|
}
|
|
|
|
}
|
|
|
|
result.push_str(line);
|
|
|
|
result.push('\n');
|
|
|
|
}
|
|
|
|
result
|
|
|
|
}
|
|
|
|
|
|
|
|
#[cargo_test]
|
|
|
|
fn deduplicate_messages_basic() {
|
|
|
|
let p = project()
|
|
|
|
.file(
|
|
|
|
"src/lib.rs",
|
|
|
|
r#"
|
|
|
|
pub fn foo() {
|
|
|
|
let x = 1;
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
)
|
|
|
|
.build();
|
|
|
|
let rustc_message = raw_rustc_output(&p, "src/lib.rs", &[]);
|
|
|
|
let expected_output = format!(
|
|
|
|
"{}\
|
2024-02-01 03:47:27 +00:00
|
|
|
warning: `foo` (lib) generated 1 warning[..]
|
2021-07-09 22:30:15 +00:00
|
|
|
warning: `foo` (lib test) generated 1 warning (1 duplicate)
|
|
|
|
[FINISHED] [..]
|
2022-01-31 18:37:02 +00:00
|
|
|
[EXECUTABLE] unittests src/lib.rs (target/debug/deps/foo-[..][EXE])
|
2021-07-09 22:30:15 +00:00
|
|
|
",
|
|
|
|
rustc_message
|
|
|
|
);
|
|
|
|
p.cargo("test --no-run -j1")
|
|
|
|
.with_stderr(&format!("[COMPILING] foo [..]\n{}", expected_output))
|
|
|
|
.run();
|
|
|
|
// Run again, to check for caching behavior.
|
|
|
|
p.cargo("test --no-run -j1")
|
|
|
|
.with_stderr(expected_output)
|
|
|
|
.run();
|
|
|
|
}
|
|
|
|
|
|
|
|
#[cargo_test]
|
|
|
|
fn deduplicate_messages_mismatched_warnings() {
|
|
|
|
// One execution prints 1 warning, the other prints 2 where there is an overlap.
|
|
|
|
let p = project()
|
|
|
|
.file(
|
|
|
|
"src/lib.rs",
|
|
|
|
r#"
|
|
|
|
pub fn foo() {
|
|
|
|
let x = 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn t1() {
|
|
|
|
let MY_VALUE = 1;
|
|
|
|
assert_eq!(MY_VALUE, 1);
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
)
|
|
|
|
.build();
|
|
|
|
let lib_output = raw_rustc_output(&p, "src/lib.rs", &[]);
|
|
|
|
let mut lib_test_output = raw_rustc_output(&p, "src/lib.rs", &["--test"]);
|
|
|
|
// Remove the duplicate warning.
|
|
|
|
let start = lib_test_output.find(&lib_output).expect("same warning");
|
|
|
|
lib_test_output.replace_range(start..start + lib_output.len(), "");
|
|
|
|
let expected_output = format!(
|
|
|
|
"\
|
|
|
|
{}\
|
2024-02-01 03:47:27 +00:00
|
|
|
warning: `foo` (lib) generated 1 warning[..]
|
2021-07-09 22:30:15 +00:00
|
|
|
{}\
|
|
|
|
warning: `foo` (lib test) generated 2 warnings (1 duplicate)
|
|
|
|
[FINISHED] [..]
|
2022-01-31 18:37:02 +00:00
|
|
|
[EXECUTABLE] unittests src/lib.rs (target/debug/deps/foo-[..][EXE])
|
2021-07-09 22:30:15 +00:00
|
|
|
",
|
|
|
|
lib_output, lib_test_output
|
|
|
|
);
|
|
|
|
p.cargo("test --no-run -j1")
|
|
|
|
.with_stderr(&format!("[COMPILING] foo v0.0.1 [..]\n{}", expected_output))
|
|
|
|
.run();
|
|
|
|
// Run again, to check for caching behavior.
|
|
|
|
p.cargo("test --no-run -j1")
|
|
|
|
.with_stderr(expected_output)
|
|
|
|
.run();
|
|
|
|
}
|
2021-07-16 00:37:21 +00:00
|
|
|
|
|
|
|
#[cargo_test]
|
|
|
|
fn deduplicate_errors() {
|
|
|
|
let p = project()
|
|
|
|
.file(
|
|
|
|
"src/lib.rs",
|
|
|
|
r#"
|
|
|
|
this should not compile
|
|
|
|
"#,
|
|
|
|
)
|
|
|
|
.build();
|
|
|
|
let rustc_message = raw_rustc_output(&p, "src/lib.rs", &[]);
|
|
|
|
p.cargo("test -j1")
|
|
|
|
.with_status(101)
|
|
|
|
.with_stderr(&format!(
|
|
|
|
"\
|
|
|
|
[COMPILING] foo v0.0.1 [..]
|
2023-08-09 15:19:59 +00:00
|
|
|
{}error: could not compile `foo` (lib) due to 1 previous error
|
2021-07-16 00:37:21 +00:00
|
|
|
",
|
|
|
|
rustc_message
|
|
|
|
))
|
|
|
|
.run();
|
|
|
|
}
|