cargo/clippy.toml

allow-print-in-tests = true
allow-dbg-in-tests = true
disallowed-methods = [
    { path = "std::env::var", reason = "use `Config::get_env` instead. See rust-lang/cargo#11588" },
    { path = "std::env::var_os", reason = "use `Config::get_env_os` instead. See rust-lang/cargo#11588" },
    { path = "std::env::vars", reason = "not recommended to use in Cargo. See rust-lang/cargo#11588" },
    { path = "std::env::vars_os", reason = "not recommended to use in Cargo. See rust-lang/cargo#11588" },
]
disallowed-types = [
    { path = "std::sync::atomic::AtomicU64", reason = "not portable. See rust-lang/cargo#12988" },
]
chore: Migrate print-ban from test to clippy This should be more resilient to false positives like in #12245 where a string contains `println`. 2023-06-09 02:39:43 +00:00			`allow-print-in-tests = true`
			`allow-dbg-in-tests = true`
clippy: warn `disallowed_methods` for `std::env::var` and friends In 11588 we want to avoid reading from environment variables, 11727 did that well. I wonder if we could leverage tools to help with this. Thankfully, clippy has a `disallowed_methods`[1] lint, helping us enforce the rule. [1]: https://rust-lang.github.io/rust-clippy/stable/index.html#disallowed_methods 2023-03-17 09:24:42 +00:00			`disallowed-methods = [`
lint: follow convention no capitcal letter in first word 2023-09-12 01:16:36 +00:00			{ path = "std::env::var", reason = "use `Config::get_env` instead. See rust-lang/cargo#11588" },
			{ path = "std::env::var_os", reason = "use `Config::get_env_os` instead. See rust-lang/cargo#11588" },
			`{ path = "std::env::vars", reason = "not recommended to use in Cargo. See rust-lang/cargo#11588" },`
			`{ path = "std::env::vars_os", reason = "not recommended to use in Cargo. See rust-lang/cargo#11588" },`
clippy: warn `disallowed_methods` for `std::env::var` and friends In 11588 we want to avoid reading from environment variables, 11727 did that well. I wonder if we could leverage tools to help with this. Thankfully, clippy has a `disallowed_methods`[1] lint, helping us enforce the rule. [1]: https://rust-lang.github.io/rust-clippy/stable/index.html#disallowed_methods 2023-03-17 09:24:42 +00:00			`]`
chore(ci): Catch naive use of AtomicU64 early AtomicU64 is not portable and use of it, without `target_has_atomic`, will fail CI for rust-lang/rust when the cargo submodule gets updated (see #12981). If there is a reason to use it, we could always `allow` in that one case. 2023-11-16 17:58:58 +00:00			`disallowed-types = [`
chore: Communicate motivation for AtomucU64 Co-authored-by: Weihang Lo <weihanglo@users.noreply.github.com> 2023-11-16 18:34:02 +00:00			`{ path = "std::sync::atomic::AtomicU64", reason = "not portable. See rust-lang/cargo#12988" },`
chore(ci): Catch naive use of AtomicU64 early AtomicU64 is not portable and use of it, without `target_has_atomic`, will fail CI for rust-lang/rust when the cargo submodule gets updated (see #12981). If there is a reason to use it, we could always `allow` in that one case. 2023-11-16 17:58:58 +00:00			`]`