ci(golangci-lint): switch to latest (#870)

* ci(golangci-lint): switch to latest

remove schema override since it was fixed in upstream

Signed-off-by: hackercat <me@hackerc.at>

* fix: apply lint fixes

.github/workflows/checks.yml

@@ -21,7 +21,7 @@ jobs:
         env:
           CGO_ENABLED: 0
         with:
-          version: v1.40.0
+          version: latest
       - uses: github/super-linter@v3
         env:
           DEFAULT_BRANCH: master

.golangci.yml

@@ -1,7 +1,4 @@
-# yaml-language-server: $schema=https://schemastore.pages.dev/schemas/json/golangci-lint.json
-# Your editor might complain about invalid types, but this is correct config
-# above schema should prevent editor from "shouting" about this
-# Minimum golangci-lint version required: v1.40.0
+# Minimum golangci-lint version required: v1.42.0
 run:
   timeout: 3m
 
@@ -32,7 +29,7 @@ linters:
   enable:
     - megacheck
     - govet
-    - golint
+    - revive
     - gocyclo
     - gosec
     - unconvert

pkg/runner/runner_test.go

@@ -16,7 +16,7 @@ import (
 	"github.com/nektos/act/pkg/model"
 )
 
-var baseImage string = "node:12-buster-slim"
+var baseImage = "node:12-buster-slim"
 
 func init() {
 	if p := os.Getenv("ACT_TEST_IMAGE"); p != "" {

pkg/runner/step_context.go

@@ -560,7 +560,7 @@ func (sc *StepContext) execAsDocker(ctx context.Context, action *model.Action, a
 
 		if !correctArchExists {
 			log.Debugf("image '%s' for architecture '%s' will be built from context '%s", image, rc.Config.ContainerArchitecture, contextDir)
-			var actionContainer container.Container = nil
+			var actionContainer container.Container
 			if localAction {
 				actionContainer = sc.RunContext.JobContainer
 			}