crates/rust-url
crates/rust-url
1
0
Fork 0
mirror of https://github.com/servo/rust-url synced 2024-10-18 14:02:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf(url): avoid trivial reallocs

Browse source
This commit is contained in:
Aaron O'Mullan 2022-04-01 21:25:11 +02:00
parent 48fcbe1c54
commit 519bbb5b3a
3 changed files with 14 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
idna/src/uts46.rs
View file

@ -554,7 +554,7 @@ impl Config {
/// http://www.unicode.org/reports/tr46/#ToASCII
pub fn to_ascii(self, domain: &str) -> Result<String, Errors> {
let mut result = String::new();
let mut result = String::with_capacity(domain.len());
let mut codec = Idna::new(self);
codec.to_ascii(domain, &mut result).map(|()| result)
}

9
url/benches/parse_url.rs
View file

@ -12,5 +12,12 @@ fn short(bench: &mut Bencher) {
bench.iter(|| black_box(url).parse::<Url>().unwrap());
}
benchmark_group!(benches, short);
fn long(bench: &mut Bencher) {
let url = "https://example.com/parkbench?tre=es&st=uff";
bench.bytes = url.len() as u64;
bench.iter(|| black_box(url).parse::<Url>().unwrap());
}
benchmark_group!(benches, short, long);
benchmark_main!(benches);

11
url/src/parser.rs
View file

@ -1216,13 +1216,11 @@ impl<'a> Parser<'a> {
}
}
}
// Going from &str to String to &str to please the 1.33.0 borrow checker
let before_slash_string = if ends_with_slash {
self.serialization[segment_start..self.serialization.len() - 1].to_owned()
let segment_before_slash = if ends_with_slash {
&self.serialization[segment_start..self.serialization.len() - 1]
} else {
self.serialization[segment_start..self.serialization.len()].to_owned()
&self.serialization[segment_start..self.serialization.len()]
};
let segment_before_slash: &str = &before_slash_string;
match segment_before_slash {
// If buffer is a double-dot path segment, shorten url’s path,
".." | "%2e%2e" | "%2e%2E" | "%2E%2e" | "%2E%2E" | "%2e." | "%2E." | ".%2e"
@ -1412,7 +1410,8 @@ impl<'a> Parser<'a> {
scheme_end: u32,
mut input: Input<'i>,
) -> Option<Input<'i>> {
let mut query = String::new(); // FIXME: use a streaming decoder instead
let len = input.chars.as_str().len();
let mut query = String::with_capacity(len); // FIXME: use a streaming decoder instead
let mut remaining = None;
while let Some(c) = input.next() {
if c == '#' && self.context == Context::UrlParser {