mirror of
https://github.com/containers/podman
synced 2024-10-21 01:34:37 +00:00
bf94ebf423
Fix day-one sloppiness: when I first wrote this framework
it compared strings using 'expr', not '=', to be more
forgiving of extra cruft in output. This was a bad decision.
It means that warnings or additional text are ignored:
is "all is ok, NOT!" "all is ok" <-- this would pass
Solution: tighten up the 'is' check. Use '=' (direct
compare) first. If it fails, look for wild cards ('*')
or character classes ('[') in the expect string. If
so, and only then, use 'expr'. And, thanks to a clever
suggestion from Luap99, include '(using expr)' in the
error message when we do so; this could make it easier
for a developer to understand a string mismatch.
This change exposes a lot of instances in which we weren't
doing proper comparisons. Fix those. Thankfully, there
weren't as many as I'd feared.
Also, and completely unrelated, add '-T' flag to bats
helper, for showing timing results. (I will open this
as a separate PR if requested. I too find it offensive
to jumble together unrelated commits.)
Signed-off-by: Ed Santiago <santiago@redhat.com>
100 lines
3.1 KiB
Bash
100 lines
3.1 KiB
Bash
#!/usr/bin/env bats
|
|
|
|
load helpers
|
|
|
|
@test "podman info - basic test" {
|
|
run_podman info
|
|
|
|
expected_keys="
|
|
buildahVersion: *[0-9.]\\\+
|
|
conmon:\\\s\\\+package:
|
|
distribution:
|
|
logDriver:
|
|
ociRuntime:\\\s\\\+name:
|
|
os:
|
|
rootless:
|
|
registries:
|
|
store:
|
|
graphDriverName:
|
|
graphRoot:
|
|
graphStatus:
|
|
imageStore:\\\s\\\+number: 1
|
|
runRoot:
|
|
cgroupManager: \\\(systemd\\\|cgroupfs\\\)
|
|
cgroupVersion: v[12]
|
|
"
|
|
while read expect; do
|
|
is "$output" ".*$expect" "output includes '$expect'"
|
|
done < <(parse_table "$expected_keys")
|
|
}
|
|
|
|
@test "podman info - json" {
|
|
run_podman info --format=json
|
|
|
|
expr_nvr="[a-z0-9-]\\\+-[a-z0-9.]\\\+-[a-z0-9]\\\+\."
|
|
expr_path="/[a-z0-9\\\/.-]\\\+\\\$"
|
|
|
|
# FIXME: if we're ever able to get package versions on Debian,
|
|
# add '-[0-9]' to all '*.package' queries below.
|
|
tests="
|
|
host.buildahVersion | [1-9][0-9]*\.[0-9.]\\\+.*
|
|
host.conmon.path | $expr_path
|
|
host.conmon.package | .*conmon.*
|
|
host.cgroupManager | \\\(systemd\\\|cgroupfs\\\)
|
|
host.cgroupVersion | v[12]
|
|
host.ociRuntime.path | $expr_path
|
|
host.ociRuntime.package | .*\\\(crun\\\|runc\\\).*
|
|
store.configFile | $expr_path
|
|
store.graphDriverName | [a-z0-9]\\\+\\\$
|
|
store.graphRoot | $expr_path
|
|
store.imageStore.number | 1
|
|
host.slirp4netns.executable | $expr_path
|
|
"
|
|
|
|
parse_table "$tests" | while read field expect; do
|
|
actual=$(echo "$output" | jq -r ".$field")
|
|
dprint "# actual=<$actual> expect=<$expect>"
|
|
is "$actual" "$expect" "jq .$field"
|
|
done
|
|
|
|
}
|
|
|
|
# 2021-04-06 discussed in watercooler: RHEL must never use crun, even if
|
|
# using cgroups v2.
|
|
@test "podman info - RHEL8 must use runc" {
|
|
local osrelease=/etc/os-release
|
|
test -e $osrelease || skip "Not a RHEL system (no $osrelease)"
|
|
|
|
local osname=$(source $osrelease; echo $NAME)
|
|
if [[ $osname =~ Red.Hat || $osname =~ CentOS ]]; then
|
|
# Version can include minor; strip off first dot an all beyond it
|
|
local osver=$(source $osrelease; echo $VERSION_ID)
|
|
test ${osver%%.*} -le 8 || skip "$osname $osver > RHEL8"
|
|
|
|
# RHEL or CentOS 8.
|
|
# FIXME: what does 'CentOS 8' even mean? What is $VERSION_ID in CentOS?
|
|
is "$(podman_runtime)" "runc" "$osname only supports OCI Runtime = runc"
|
|
else
|
|
skip "only applicable on RHEL, this is $osname"
|
|
fi
|
|
}
|
|
|
|
@test "podman info --storage-opt='' " {
|
|
skip_if_remote "--storage-opt flag is not supported for remote"
|
|
skip_if_rootless "storage opts are required for rootless running"
|
|
run_podman --storage-opt='' info
|
|
# Note this will not work in rootless mode, unless you specify
|
|
# storage-driver=vfs, until we have kernels that support rootless overlay
|
|
# mounts.
|
|
is "$output" ".*graphOptions: {}" "output includes graphOptions: {}"
|
|
}
|
|
|
|
@test "podman --root PATH info - basic output" {
|
|
if ! is_remote; then
|
|
run_podman --storage-driver=vfs --root ${PODMAN_TMPDIR}/nothing-here-move-along info --format '{{ .Store.GraphOptions }}'
|
|
is "$output" "map\[\]" "'podman --root should reset Graphoptions to []"
|
|
fi
|
|
}
|
|
|
|
# vim: filetype=sh
|