mirror of
https://github.com/containers/podman
synced 2024-10-19 16:54:07 +00:00
2bb2425704
Make Podman pod operations that do not involve starting containers (which needs to be done in a specific order) use the same parallel operation code we use to make `podman stop` on large numbers of containers fast. We were previously stopping containers in a pod serially, which could take up to the timeout (default 15 seconds) for each container - stopping 100 containers that do not respond to SIGTERM would take 25 minutes. To do this, refactor the parallel operation code a bit to remove its dependency on libpod (damn circular import restrictions...) and use parallel functions that just re-use the standard container API operations - maximizes code reuse (previously each pod handler had a separate implementation of the container function it performed). This is a bit of a palate cleanser after fighting CI for two days - nice to be able to return to a land of sanity. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
41 lines
1.1 KiB
Go
41 lines
1.1 KiB
Go
package ctr
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/containers/podman/v2/libpod"
|
|
"github.com/containers/podman/v2/pkg/parallel"
|
|
"github.com/sirupsen/logrus"
|
|
)
|
|
|
|
// ContainerOp performs the given function on the given set of
|
|
// containers, using a number of parallel threads.
|
|
// If no error is returned, each container specified in ctrs will have an entry
|
|
// in the resulting map; containers with no error will be set to nil.
|
|
func ContainerOp(ctx context.Context, ctrs []*libpod.Container, applyFunc func(*libpod.Container) error) (map[*libpod.Container]error, error) {
|
|
// We could use a sync.Map but given Go's lack of generic I'd rather
|
|
// just use a lock on a normal map...
|
|
// The expectation is that most of the time is spent in applyFunc
|
|
// anyways.
|
|
var (
|
|
errMap = make(map[*libpod.Container]<-chan error)
|
|
)
|
|
|
|
for _, ctr := range ctrs {
|
|
c := ctr
|
|
logrus.Debugf("Starting parallel job on container %s", c.ID())
|
|
errChan := parallel.Enqueue(ctx, func() error {
|
|
return applyFunc(c)
|
|
})
|
|
errMap[c] = errChan
|
|
}
|
|
|
|
finalErr := make(map[*libpod.Container]error)
|
|
for ctr, errChan := range errMap {
|
|
err := <-errChan
|
|
finalErr[ctr] = err
|
|
}
|
|
|
|
return finalErr, nil
|
|
}
|