mirror of
https://github.com/containers/podman
synced 2024-10-19 16:54:07 +00:00
c8f9117cef
A reading of LabelVolumePath suggests that the intended behavior upon encountering ENOTSUP is to log the issue and continue without error, while all other errors in the Relabeling operation should be considered errors of LabelVolumePath and passed up accordingly. This is not the behavior that is encountered, as this test shows: it is instead considered an error if and only if the Relabeling operation returns ENOTSUP, spitting out a somewhat incongruous error message, while all other error types that may be returned are logged without being propogated, with an even more incongruous error message saying that the operation was not supported. The comparison was changed to match the behavior documented by the log messages, and a test was added that will simulate executing this function on a path where the mounted filesystem does not support SELinux labels, with the assertion that the function should not return an error in order to highlight the condition these changes seek to alleviate. Signed-off-by: Peter <peter@psanders.me>
40 lines
1,021 B
Go
40 lines
1,021 B
Go
package libpod
|
|
|
|
import (
|
|
"syscall"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestLabelVolumePath(t *testing.T) {
|
|
// Set up mocked SELinux functions for testing.
|
|
oldRelabel := lvpRelabel
|
|
oldInitLabels := lvpInitLabels
|
|
oldReleaseLabel := lvpReleaseLabel
|
|
defer func() {
|
|
lvpRelabel = oldRelabel
|
|
lvpInitLabels = oldInitLabels
|
|
lvpReleaseLabel = oldReleaseLabel
|
|
}()
|
|
|
|
// Relabel returns ENOTSUP unconditionally.
|
|
lvpRelabel = func(path string, fileLabel string, shared bool) error {
|
|
return syscall.ENOTSUP
|
|
}
|
|
|
|
// InitLabels and ReleaseLabel both return dummy values and nil errors.
|
|
lvpInitLabels = func(options []string) (string, string, error) {
|
|
pLabel := "system_u:system_r:container_t:s0:c1,c2"
|
|
mLabel := "system_u:object_r:container_file_t:s0:c1,c2"
|
|
return pLabel, mLabel, nil
|
|
}
|
|
lvpReleaseLabel = func(label string) error {
|
|
return nil
|
|
}
|
|
|
|
// LabelVolumePath should not return an error if the operation is unsupported.
|
|
err := LabelVolumePath("/foo/bar")
|
|
assert.NoError(t, err)
|
|
}
|