mirror of
https://github.com/containers/podman
synced 2024-10-20 17:23:30 +00:00
bf94ebf423
Fix day-one sloppiness: when I first wrote this framework
it compared strings using 'expr', not '=', to be more
forgiving of extra cruft in output. This was a bad decision.
It means that warnings or additional text are ignored:
is "all is ok, NOT!" "all is ok" <-- this would pass
Solution: tighten up the 'is' check. Use '=' (direct
compare) first. If it fails, look for wild cards ('*')
or character classes ('[') in the expect string. If
so, and only then, use 'expr'. And, thanks to a clever
suggestion from Luap99, include '(using expr)' in the
error message when we do so; this could make it easier
for a developer to understand a string mismatch.
This change exposes a lot of instances in which we weren't
doing proper comparisons. Fix those. Thankfully, there
weren't as many as I'd feared.
Also, and completely unrelated, add '-T' flag to bats
helper, for showing timing results. (I will open this
as a separate PR if requested. I too find it offensive
to jumble together unrelated commits.)
Signed-off-by: Ed Santiago <santiago@redhat.com>
|
||
|---|---|---|
| .. | ||
| podman-registry-go | ||
| apparmor_tag.sh | ||
| bats | ||
| branch_commits.rb | ||
| btrfs_installed_tag.sh | ||
| btrfs_tag.sh | ||
| check_root.sh | ||
| get_ci_vm.sh | ||
| golangci-lint.sh | ||
| install_bats.sh | ||
| install_catatonit.sh | ||
| install_golangci.sh | ||
| libdm_tag.sh | ||
| libsubid_tag.sh | ||
| man-page-checker | ||
| podman-commands.sh | ||
| podman-registry | ||
| podman-socat | ||
| podmanv2-retry | ||
| release.sh | ||
| selinux_tag.sh | ||
| swagger-check | ||
| systemd_tag.sh | ||
| tree_status.sh | ||
| xref-helpmsgs-manpages | ||