mirror of
https://github.com/containers/podman
synced 2024-10-20 17:23:30 +00:00
49e696642d
This flag switches to removing containers directly from c/storage and is mostly used to remove orphan containers. It's a superior solution to our former one, which attempted removal from storage under certain circumstances and could, under some conditions, not trigger. Also contains the beginning of support for storage in `ps` but wiring that in is going to be a much bigger pain. Fixes #3329. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
119 lines
3.4 KiB
Go
119 lines
3.4 KiB
Go
package libpod
|
|
|
|
import (
|
|
"github.com/containers/storage"
|
|
"github.com/pkg/errors"
|
|
"github.com/sirupsen/logrus"
|
|
)
|
|
|
|
// StorageContainer represents a container present in c/storage but not in
|
|
// libpod.
|
|
type StorageContainer struct {
|
|
ID string
|
|
Names []string
|
|
PresentInLibpod bool
|
|
}
|
|
|
|
// ListStorageContainers lists all containers visible to c/storage.
|
|
func (r *Runtime) ListStorageContainers() ([]*StorageContainer, error) {
|
|
r.lock.RLock()
|
|
defer r.lock.RUnlock()
|
|
|
|
finalCtrs := []*StorageContainer{}
|
|
|
|
ctrs, err := r.store.Containers()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
for _, ctr := range ctrs {
|
|
storageCtr := new(StorageContainer)
|
|
storageCtr.ID = ctr.ID
|
|
storageCtr.Names = ctr.Names
|
|
|
|
// Look up if container is in state
|
|
hasCtr, err := r.state.HasContainer(ctr.ID)
|
|
if err != nil {
|
|
return nil, errors.Wrapf(err, "error looking up container %s in state", ctr.ID)
|
|
}
|
|
|
|
storageCtr.PresentInLibpod = hasCtr
|
|
|
|
finalCtrs = append(finalCtrs, storageCtr)
|
|
}
|
|
|
|
return finalCtrs, nil
|
|
}
|
|
|
|
// RemoveStorageContainer removes a container from c/storage.
|
|
// The container WILL NOT be removed if it exists in libpod.
|
|
// Accepts ID or full name of container.
|
|
// If force is set, the container will be unmounted first to ensure removal.
|
|
func (r *Runtime) RemoveStorageContainer(idOrName string, force bool) error {
|
|
r.lock.Lock()
|
|
defer r.lock.Unlock()
|
|
|
|
targetID, err := r.store.Lookup(idOrName)
|
|
if err != nil {
|
|
if err == storage.ErrLayerUnknown {
|
|
return errors.Wrapf(ErrNoSuchCtr, "no container with ID or name %q found", idOrName)
|
|
}
|
|
return errors.Wrapf(err, "error looking up container %q", idOrName)
|
|
}
|
|
|
|
// Lookup returns an ID but it's not guaranteed to be a container ID.
|
|
// So we can still error here.
|
|
ctr, err := r.store.Container(targetID)
|
|
if err != nil {
|
|
if err == storage.ErrContainerUnknown {
|
|
return errors.Wrapf(ErrNoSuchCtr, "%q does not refer to a container", idOrName)
|
|
}
|
|
return errors.Wrapf(err, "error retrieving container %q", idOrName)
|
|
}
|
|
|
|
// Error out if the container exists in libpod
|
|
exists, err := r.state.HasContainer(ctr.ID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if exists {
|
|
return errors.Wrapf(ErrCtrExists, "refusing to remove %q as it exists in libpod as container %s", idOrName, ctr.ID)
|
|
}
|
|
|
|
if !force {
|
|
timesMounted, err := r.store.Mounted(ctr.ID)
|
|
if err != nil {
|
|
if err == storage.ErrContainerUnknown {
|
|
// Container was removed from under us.
|
|
// It's gone, so don't bother erroring.
|
|
logrus.Warnf("Storage for container %s already removed", ctr.ID)
|
|
return nil
|
|
}
|
|
return errors.Wrapf(err, "error looking up container %q mounts", idOrName)
|
|
}
|
|
if timesMounted > 0 {
|
|
return errors.Wrapf(ErrCtrStateInvalid, "container %q is mounted and cannot be removed without using force", idOrName)
|
|
}
|
|
} else {
|
|
if _, err := r.store.Unmount(ctr.ID, true); err != nil {
|
|
if err == storage.ErrContainerUnknown {
|
|
// Container again gone, no error
|
|
logrus.Warnf("Storage for container %s already removed", ctr.ID)
|
|
return nil
|
|
}
|
|
return errors.Wrapf(err, "error unmounting container %q", idOrName)
|
|
}
|
|
}
|
|
|
|
if err := r.store.DeleteContainer(ctr.ID); err != nil {
|
|
if err == storage.ErrContainerUnknown {
|
|
// Container again gone, no error
|
|
logrus.Warnf("Storage for container %s already removed", ctr.ID)
|
|
return nil
|
|
}
|
|
return errors.Wrapf(err, "error removing storage for container %q", idOrName)
|
|
}
|
|
|
|
return nil
|
|
}
|