mirror of
https://github.com/containers/podman
synced 2024-10-21 01:34:37 +00:00
e938345760
While we have these string literals on repeated on multiple places in the
library, I cannot see real tangible benefit extracting these to constants
considering following facts:
(1) while 'unknown' or 'host' are repeated, they are often times used in
different context and thus perhaps worth extra const per each use.
(2) while these string literals repeat, the library is full of string literals
with special meaning that should be made constants too
(3) readability would suffer
Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
49 lines
1.7 KiB
Bash
Executable file
49 lines
1.7 KiB
Bash
Executable file
#!/usr/bin/env bash
|
|
|
|
set -o errexit
|
|
set -o nounset
|
|
set -o pipefail
|
|
|
|
# Create the linter path for use later
|
|
LINTER=${GOPATH}/bin/gometalinter
|
|
|
|
# Make sure gometalinter is installed
|
|
if [ ! -f ${LINTER} ]; then
|
|
echo >&2 "gometalinter must be installed. Please run 'make install.tools' and try again"
|
|
exit 1
|
|
fi
|
|
|
|
PKGS=$(find . -type d -not -path . -a -not -iwholename '*.git*' -a -not -iname '.tool' -a -not -iwholename '*vendor*' -a -not -iname 'hack' -a -not -iwholename '*.artifacts*' -a -not -iwholename '*contrib*' -a -not -iwholename '*test*' -a -not -iwholename '*logo*' -a -not -iwholename '*conmon*' -a -not -iwholename '*completions*' -a -not -iwholename '*docs*' -a -not -iwholename '*pause*' -a -not -iwholename './_output*' -a -not -iwholename '*ioprojectatomicpodman.go')
|
|
|
|
echo $PKGS
|
|
|
|
# Execute the linter
|
|
${LINTER} \
|
|
--concurrency=4\
|
|
--enable-gc\
|
|
--vendored-linters\
|
|
--deadline=600s --disable-all\
|
|
--enable=deadcode\
|
|
--enable=errcheck\
|
|
--enable=goconst\
|
|
--enable=gofmt\
|
|
--enable=golint\
|
|
--enable=ineffassign\
|
|
--enable=megacheck\
|
|
--enable=misspell\
|
|
--enable=structcheck\
|
|
--enable=varcheck\
|
|
--enable=vet\
|
|
--enable=vetshadow\
|
|
--exclude='error return value not checked.*\(errcheck\)$'\
|
|
--exclude='declaration of.*err.*shadows declaration.*\(vetshadow\)$'\
|
|
--exclude='.*_test\.go:.*error return value not checked.*\(errcheck\)$'\
|
|
--exclude='duplicate of.*_test.go.*\(dupl\)$'\
|
|
--exclude='cmd\/client\/.*\.go.*\(dupl\)$'\
|
|
--exclude='libpod\/.*_easyjson.go:.*'\
|
|
--exclude='.* other occurrence\(s\) of "(container|host|tmpfs|unknown)" found in: .*\(goconst\)$'\
|
|
--exclude='vendor\/.*'\
|
|
--exclude='podman\/.*'\
|
|
--exclude='server\/seccomp\/.*\.go.*$'\
|
|
${PKGS[@]}
|