Commit graph

8 commits

Author SHA1 Message Date
Valentin Rothberg a36974585f CONTRIBUTING.md: add section about describing changes
Add a section about describing changes in commit messages.  GitHub tends
to drive the large part of discussions and change descriptions to the
corresponding pull requests and issues, but such information is lost in
the git history.  Not providing sufficient information in commit
messages is painful for reviewing and can cause issues while debugging.
It also complicates studying source code, where reading commit messages
and the code's git history is a common approach to better understand the
code.

Following the descriptions should be enforced by the maintainers of the
libpod project.  Pull requests containing commits without proper
descriptions should not be merged.

This change bases on the documentation of the Linux kernel v4.17:
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html

Signed-off-by: Valentin Rothberg <vrothberg@suse.com>
2018-10-29 13:13:34 +01:00
Daniel J Walsh d20f3a5146 switch projectatomic to containers
Need to get some small changes into libpod to pull back into buildah
to complete buildah transition.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

Closes: #1270
Approved by: mheon
2018-08-16 17:12:36 +00:00
TomSweeneyRedHat 781eec27b5 Add pointers for Integration Tests to docs
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>

Closes: #910
Approved by: rhatdan
2018-06-06 18:45:57 +00:00
W. Trevor King eda0fd7468 CONTRIBUTING: Document PR approval and link to OWNERS
Remove a dead "Becoming a Maintainer" link and that stub section,
since libpod currently doesn't document that process.  By leaving it
undocumented, maintainer changes falls back to the usual pull-request
review process.

Signed-off-by: W. Trevor King <wking@tremily.us>

Closes: #688
Approved by: rhatdan
2018-04-28 07:45:30 +00:00
W. Trevor King 4e468ce83d README: Link to CONTRIBUTING.md
Make that information more easily discoverable.  And since
CONTRIBUTING.md already mentions IRC, we can drop the IRC reference
from the README to DRY things up.

Also update CONTRIBUTING.md to replace the stale #cri-o reference left
over from the initial libpod/podman fork.  While I was touching this
line, I also shuffled some of the wording around to tighten that
sentence up.

Signed-off-by: W. Trevor King <wking@tremily.us>

Closes: #687
Approved by: rhatdan
2018-04-27 19:05:46 +00:00
Daniel J Walsh 099b5fb6f6 Ran spell checker through all man pages
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

Closes: #269
Approved by: TomSweeneyRedHat
2018-01-29 15:21:34 +00:00
Matthew Heon c13f61798a Prune Server package. Convert to new github location.
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
2017-11-01 13:22:04 -04:00
Matthew Heon a031b83a09 Initial checkin from CRI-O repo
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
2017-11-01 11:24:59 -04:00