container/podman
container/podman
1
0
Fork 0
mirror of https://github.com/containers/podman synced 2024-10-19 08:44:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

enable --iidfile for podman-remote build

Browse source 
for podman-remote build operations, the iidfile, when used, needs to write the file to the client's local filesystem.

Signed-off-by: baude <bbaude@redhat.com>
This commit is contained in:
baude 2020-09-17 12:55:48 -05:00
parent 031ddf9c84
commit ec58650939
2 changed files with 16 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
pkg/domain/infra/tunnel/images.go
View file

@ -306,7 +306,22 @@ func (ir *ImageEngine) Config(_ context.Context) (*config.Config, error) {
}
func (ir *ImageEngine) Build(_ context.Context, containerFiles []string, opts entities.BuildOptions) (*entities.BuildReport, error) {
return images.Build(ir.ClientCxt, containerFiles, opts)
report, err := images.Build(ir.ClientCxt, containerFiles, opts)
if err != nil {
return nil, err
}
// For remote clients, if the option for writing to a file was
// selected, we need to write to the *client's* filesystem.
if len(opts.IIDFile) > 0 {
f, err := os.Create(opts.IIDFile)
if err != nil {
return nil, err
}
if _, err := f.WriteString(report.ID); err != nil {
return nil, err
}
}
return report, nil
}
func (ir *ImageEngine) Tree(ctx context.Context, nameOrID string, opts entities.ImageTreeOptions) (*entities.ImageTreeReport, error) {

2
test/e2e/build_test.go
View file

@ -179,8 +179,6 @@ var _ = Describe("Podman build", func() {
})
It("podman build basic alpine and print id to external file", func() {
SkipIfRemote()
// Switch to temp dir and restore it afterwards
cwd, err := os.Getwd()
Expect(err).To(BeNil())